chore(deps): upgrade jest #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anshumanv
reviewed
Mar 27, 2020
packages/utils/package.json
Outdated
| @@ -24,7 +24,7 @@ | |||
| "@types/got": "9.6.9", | |||
| "@types/prettier": "1.19.0", | |||
| "@types/yeoman-generator": "3.1.4", | |||
| "jest": "25.1.0" | |||
| "jest": "25.2.3" | |||
There was a problem hiding this comment.
We don't need it here, we have it at the root already.
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Tests seem to be running fine for me, can you yarn and yarn bootstrap after pulling the latest? |
Yes I did a fresh clone, yarn install, yarn bootstrap, yarn build Using Zorin OS 15.2 (based on Ubuntu 18.04), Node v10.13.0 Edit: Just tried it with Node v13.12.0 and tests ran fine. Not sure exactly what versions webpack-cli is trying to support. Anyway, I think upgrading jest here can't hurt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fix/chore
Did you add tests for your changes?
no
If relevant, did you update the documentation?
N/A
Summary
Solves #1386 for me
Does this PR introduce a breaking change?
No
Other information