tests: increase coverage for webpack-scaffold #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesgeorge007
force-pushed
the
webpack-scaffold-tests
branch
from
4b7b546
to
c958dc4
Compare
jamesgeorge007
changed the title
anshumanv
reviewed
Apr 12, 2020
jamesgeorge007
force-pushed
the
webpack-scaffold-tests
branch
from
c958dc4
to
f4a9a4b
Compare
jamesgeorge007
force-pushed
the
webpack-scaffold-tests
branch
5 times, most recently
from
f33ce61
to
2816125
Compare
jamesgeorge007
changed the title
jamesgeorge007
force-pushed
the
webpack-scaffold-tests
branch
5 times, most recently
from
5c12d11
to
70e7535
Compare
jamesgeorge007
requested review from
alexander-akait
and removed request for
alexander-akait
alexander-akait
previously approved these changes
Apr 13, 2020
jamesgeorge007
force-pushed
the
webpack-scaffold-tests
branch
from
70e7535
to
62b1942
Compare
alexander-akait
previously approved these changes
Apr 14, 2020
jamesgeorge007
force-pushed
the
webpack-scaffold-tests
branch
from
62b1942
to
63a8120
Compare
alexander-akait
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
add test cases
Did you add tests for your changes?
Yep
If relevant, did you update the documentation?
Nope
Summary
Added missing out test cases for
webpack-scaffoldDoes this PR introduce a breaking change?
Nope
Other information
N/A