tests: remove temp loader directory before and after test #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should do this for init tests as well, since they also generate some files. |
knagaitsev
force-pushed
the
tests/rm-temp-loader
branch
from
3a4e20b
to
a890602
Compare
test/init/auto/init-auto.test.js
Outdated
| const { join } = require('path'); | ||
| const { run } = require('../../../../../test/utils/test-utils'); | ||
| const { run } = require('../..//utils/test-utils'); |
alexander-akait
previously approved these changes
Apr 20, 2020
knagaitsev
dismissed stale reviews from anshumanv and alexander-akait
via
9d4cb58
alexander-akait
approved these changes
Apr 20, 2020
jamesgeorge007
approved these changes
Apr 21, 2020
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
test fix
Did you add tests for your changes?
No
If relevant, did you update the documentation?
No
Summary
The temp directory should be removed before and after the test
Edit: I also moved
inittests to thetestdirectory and improved how they handle generated filesDoes this PR introduce a breaking change?
No
Other information