-
-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: add case to ensure entry and output resolve path same way #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
changed the title
tests: add case to ensure entry and output resolve past same way
tests: add case to ensure entry and output resolve path same way
May 5, 2020
snitin315
force-pushed
the
tests/entry
branch
4 times, most recently
from
May 6, 2020 12:51
c0fb6c0
to
869e099
Compare
/cc @rishabh3112 |
alexander-akait
previously approved these changes
May 8, 2020
Friendly ping @rishabh3112 |
jamesgeorge007
previously approved these changes
May 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Co-authored-by: James George <jamesgeorge998001@gmail.com>
snitin315
dismissed stale reviews from jamesgeorge007 and alexander-akait
via
May 12, 2020 04:38
c73f61c
Co-authored-by: James George <jamesgeorge998001@gmail.com>
alexander-akait
approved these changes
May 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @webpack/cli-team
anshumanv
approved these changes
May 12, 2020
rishabh3112
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Tests.
Refers #899
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
NA
Summary
this ensures
entry
andoutput
resolve the path the same wayDoes this PR introduce a breaking change?
NO
Other information