Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add case to ensure entry and output resolve path same way #1524

Merged
merged 4 commits into from
May 12, 2020

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?
Tests.

Refers #899

Did you add tests for your changes?
Yes

If relevant, did you update the documentation?
NA

Summary

this ensures entry and output resolve the path the same way

Does this PR introduce a breaking change?

NO

Other information

@snitin315 snitin315 requested a review from a team as a code owner May 5, 2020 12:00
@snitin315 snitin315 changed the title tests: add case to ensure entry and output resolve past same way tests: add case to ensure entry and output resolve path same way May 5, 2020
@snitin315 snitin315 force-pushed the tests/entry branch 4 times, most recently from c0fb6c0 to 869e099 Compare May 6, 2020 12:51
@snitin315
Copy link
Member Author

/cc @rishabh3112

alexander-akait
alexander-akait previously approved these changes May 8, 2020
@snitin315
Copy link
Member Author

Friendly ping @rishabh3112

jamesgeorge007
jamesgeorge007 previously approved these changes May 12, 2020
Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Co-authored-by: James George <jamesgeorge998001@gmail.com>
Co-authored-by: James George <jamesgeorge998001@gmail.com>
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @webpack/cli-team

@anshumanv anshumanv merged commit 130644e into webpack:next May 12, 2020
@snitin315 snitin315 deleted the tests/entry branch May 12, 2020 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants