chore: 馃 remove stale tests for standard flag and instances #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
reviewed
May 15, 2020
Comment on lines
-4
to
-5
| it('should print standard output', () => { | ||
| const { stdout, stderr } = run(__dirname); |
There was a problem hiding this comment.
I think this test is not for --standard flag but the default webpack output (referred to as standard). Please correct me if I'm wrong.
There was a problem hiding this comment.
No, this was used for --standard, but later --standard was dropped from the test when flag was removed.
There was a problem hiding this comment.
So, do we have another test for default output or we don't need one?
There was a problem hiding this comment.
I've added the things missing there, from this test we removed.
snitin315
previously approved these changes
May 15, 2020
alexander-akait
approved these changes
May 15, 2020
|
/cc @webpack/cli-team |
snitin315
approved these changes
May 15, 2020
rishabh3112
approved these changes
May 20, 2020
|
Let's wait for #1508 to be merged as that PR also has changes for plugin tests and those changes could be conflicting with changes here. |
alexander-akait
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Cleanup instances of standard flag, not supported anymore
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Yes
Summary
Does this PR introduce a breaking change?
No
Other information