tests: improve --node-args test cases #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anshumanv
reviewed
May 15, 2020
|
Actually it's hardcoded for --unknown flag case as well, webpack-cli/test/node/node.test.js Line 65 in 6a8dd32 So it should be changed as well. Let's wait for other opinions as well. |
evenstensberg
approved these changes
May 16, 2020
anshumanv
approved these changes
May 19, 2020
|
@evilebottnawi Thanks for your update. I labeled the Pull Request so reviewers will review it again. @anshumanv Please review the new changes. |
rishabh3112
approved these changes
May 19, 2020
|
Good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
tests
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
NA
Summary
Improved test cases to check for the specific error messages.
Does this PR introduce a breaking change?
No
Other information