tests: add tests for --target flag #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
force-pushed
the
tests/target
branch
2 times, most recently
from
d9af2fc
to
ec2ada9
Compare
snitin315
force-pushed
the
tests/target
branch
2 times, most recently
from
f4e5521
to
04ede62
Compare
|
/cc @rishabh3112 |
alexander-akait
previously approved these changes
May 25, 2020
evenstensberg
previously approved these changes
May 25, 2020
rishabh3112
requested changes
May 27, 2020
webpack-bot
added
PR: reviewed-changes-requested
and removed
PR: review-outdated
labels
snitin315
dismissed stale reviews from evenstensberg and alexander-akait
via
a3ab001
|
/cc @webpack/cli-team |
|
/cc @snitin315 Need investigate why tests failed |
|
hmm, something unusual 😕 |
|
Installing dependencies is failing, I remember encountering the same case on a PR once before, the CI was green the next day. I think its not from our end. |
|
@snitin315 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @rishabh3112 Please review the new changes. |
|
/cc @rishabh3112 |
rishabh3112
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Tests
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
No
Summary
added tests for --target
Does this PR introduce a breaking change?
NO
Other information
NO