Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: check for the existence of webpack config file #1576

Merged
merged 1 commit into from
May 24, 2020
Merged

tests: check for the existence of webpack config file #1576

merged 1 commit into from
May 24, 2020

Conversation

jamesgeorge007
Copy link
Member

@jamesgeorge007 jamesgeorge007 commented May 23, 2020 •
edited

What kind of change does this PR introduce?
refactoring

Did you add tests for your changes?
Nope

If relevant, did you update the documentation?
Nope

Summary

  • Checks whether webpack.config.js is generated as a result of init.
  • Got rid of the extraneous instruction intended to mock user behavior.

Does this PR introduce a breaking change?
Nope

Other information
N/A

@jamesgeorge007 jamesgeorge007 requested a review from a team as a code owner May 23, 2020 18:38
@anshumanv
Copy link
Member

From next time, try to point things in the PR review itself instead of sending a follow up right after merge. #1508

@jamesgeorge007
Copy link
Member Author

jamesgeorge007 commented May 23, 2020 •
edited

Just spotted it after landing that one 😅

rishabh3112
rishabh3112 requested changes May 24, 2020
View reviewed changes
Copy link
Member

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the title to more appropriately reflect the changes in PR. The addition of webpack.config.js is a major change here imo as compared to removal of one ENTER statement.

@jamesgeorge007 jamesgeorge007 changed the title tests: remove redundant instruction tests: check for the existence of webpack config file May 24, 2020
@rishabh3112 rishabh3112 merged commit 880f7ba into webpack:next May 24, 2020
@jamesgeorge007 jamesgeorge007 deleted the refactor branch May 24, 2020 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabh3112 rishabh3112 rishabh3112 approved these changes

@anshumanv anshumanv anshumanv approved these changes

Assignees
No one assigned
Labels
PR: reviewed-approved PR: reviewed-changes-requested PR: small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jamesgeorge007 @anshumanv @rishabh3112 @webpack-bot