Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add init to webpack-cli #1609

Merged
merged 11 commits into from
Jun 8, 2020
Merged

feat: add init to webpack-cli #1609

merged 11 commits into from
Jun 8, 2020

Conversation

rishabh3112
Copy link
Member

@rishabh3112 rishabh3112 commented Jun 4, 2020

What kind of change does this PR introduce?
Feature

Did you add tests for your changes?
Yes

If relevant, did you update the documentation?
Not applicable

Summary
Integrating init package into CLI so that it is available by default.

Does this PR introduce a breaking change?
No.

Other information
#1509

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need add test(s) to ensure we supported init command by default

@rishabh3112
Copy link
Member Author

Yes it is TODO as mentioned in PR description, will be working on it tonight.

@rishabh3112 rishabh3112 marked this pull request as ready for review June 4, 2020 17:47
@rishabh3112 rishabh3112 requested a review from a team as a code owner June 4, 2020 17:47
@webpack-bot
Copy link

@rishabh3112 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@anshumanv Please review the new changes.

@rishabh3112 rishabh3112 merged commit 5f4f3ea into next Jun 8, 2020
@rishabh3112 rishabh3112 deleted the init-integrate branch June 8, 2020 08:21
@rishabh3112
Copy link
Member Author

Would be refactoring jest timeouts to make them consistent in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants