Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add test for multiple config in dotfolder #1631

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

anshumanv
Copy link
Member

What kind of change does this PR introduce?

tests

Did you add tests for your changes?
Yes

If relevant, did you update the documentation?
NA

Summary

  • Add tests when there are multiple configs present in dotfolder

Does this PR introduce a breaking change?
No

Other information

@anshumanv anshumanv requested a review from a team as a code owner June 14, 2020 14:19
@alexander-akait alexander-akait merged commit 96dafdc into webpack:next Jun 15, 2020
@anshumanv
Copy link
Member Author

@evilebottnawi we presently only support reading .dev.js .prod.js files from .webpack folder, do we wish to support reading from root as well?

@anshumanv
Copy link
Member Author

Presently root only supports webpack.config.*

@alexander-akait
Copy link
Member

Yes, need support too

@anshumanv
Copy link
Member Author

Will fix 👍

@alexander-akait
Copy link
Member

@anshumanv Also webpack has none env, so I think we should support webpack.config.none.js, very rare case, but I think we should supports + I think we should support full naming like webpack.config.development.js and webpack.config.production.js

@anshumanv
Copy link
Member Author

Sounds good, will fix 👍

@anshumanv anshumanv deleted the flag-test branch July 5, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants