chore: handle unknown args and improve test suite for info #1676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesgeorge007
requested review from
alexander-akait
and removed request for
alexander-akait
jamesgeorge007
changed the title
jamesgeorge007
force-pushed
the
handle-unknown-args
branch
from
f6f2683
to
b3f6435
Compare
jamesgeorge007
changed the title
jamesgeorge007
changed the title
jamesgeorge007
force-pushed
the
handle-unknown-args
branch
from
b3f6435
to
f30581b
Compare
jamesgeorge007
force-pushed
the
handle-unknown-args
branch
from
f30581b
to
3e291e9
Compare
alexander-akait
approved these changes
Jul 13, 2020
snitin315
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
enhancement
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
N/A
Summary
webpack-cli infodidn't work as expected. Fixed it!runInfo()to be consumed across test suites.$ webpack-cli info --unknown Unknown argument: --unknown System: OS: macOS 10.15.5 CPU: (8) x64 Intel(R) Core(TM) i5-8279U CPU @ 2.40GHz Memory: 131.43 MB / 8.00 GB Binaries: Node: 13.11.0 - /usr/local/bin/node Yarn: 1.22.4 - /usr/local/bin/yarn npm: 6.14.6 - /usr/local/bin/npm Browsers: Brave Browser: 83.1.10.97 Safari: 13.1.1 Packages: webpack: ^4.43.0 => 4.43.0 Global Packages: webpack-cli: 4.0.0-beta.8Does this PR introduce a breaking change?
Nope
Other information
N/A