Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup verbose flag #1709

Merged
merged 8 commits into from
Jul 31, 2020
Merged

chore: cleanup verbose flag #1709

merged 8 commits into from
Jul 31, 2020

Conversation

anshumanv
Copy link
Member

@anshumanv anshumanv commented Jul 30, 2020

What kind of change does this PR introduce?

refactoring

Did you add tests for your changes?

Yes

If relevant, did you update the documentation?
Yes

Summary

remove verbose flag as --stats verbose is sufficient

Does this PR introduce a breaking change?
Yes

Other information
Ref - #1167

@anshumanv anshumanv requested a review from a team as a code owner July 30, 2020 16:34
@alexander-akait
Copy link
Member

After merge can you investigate other places with validation?

@anshumanv
Copy link
Member Author

After merge can you investigate other places with validation?

Yes will investigate 👍

snitin315
snitin315 previously approved these changes Jul 30, 2020
rishabh3112
rishabh3112 previously approved these changes Jul 31, 2020
Copy link
Member

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from suggestion by Nitin, Looks good to me.

@anshumanv
Copy link
Member Author

Apart from suggestion by Nitin, Looks good to me.

addressed

@rishabh3112 rishabh3112 merged commit 3b2aae7 into webpack:next Jul 31, 2020
@anshumanv anshumanv deleted the rm-verbose branch July 31, 2020 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants