[WIP-HELP-WANTED] feat: use arg parsing instead of object-oriented flag setting #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| console.log("Cannot instantiate plugin " + name + ". (" + path + ")"); | ||
| throw e; | ||
| } | ||
| } |
There was a problem hiding this comment.
We don't need it, plugin only for webpack.conifg.js configuration, trying to load enhanced-resolve break yarn PnP
| let path; | ||
| try { | ||
| const resolve = require("enhanced-resolve"); | ||
| path = resolve.sync(process.cwd(), name); |
There was a problem hiding this comment.
You don't need this, because you have require.resolve
| const loadUtils = require("loader-utils"); | ||
| let args; | ||
| try { | ||
| const p = name && name.indexOf("?"); |
There was a problem hiding this comment.
Plugins can't have ? in name
| ifArg(name, function (bool) { | ||
| if (bool === true) options[optionName || name] = true; | ||
| else if (bool === false) options[optionName || name] = false; | ||
| }); |
There was a problem hiding this comment.
Very misleading, we wee need this - optionName || name?
| finalize && finalize(); | ||
| } | ||
|
|
||
| ifArgPair(name, fn, init, finalize) { |
This was referenced Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Uses functions to set flags rather than to check existence
Did you add tests for your changes?
Not yet
If relevant, did you update the documentation?
No
Summary
WIP
Does this PR introduce a breaking change?
No
Other information
Needs help