Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow unknown files to use default require as fallback #1747

Merged
merged 2 commits into from
Aug 19, 2020
Merged

fix: allow unknown files to use default require as fallback #1747

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13e323c
fix: allow unknown files to use default require as fallback
anshumanv Aug 15, 2020
27bf777
chore: use extname instead of parse
anshumanv Aug 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 9 additions & 18 deletions packages/webpack-cli/lib/groups/ConfigGroup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
const { existsSync } = require('fs');
const { resolve, sep, dirname, parse } = require('path');
const { resolve, sep, dirname, extname } = require('path');
const webpackMerge = require('webpack-merge');
const { extensions, jsVariants } = require('interpret');
const GroupHelper = require('../utils/GroupHelper');
Expand Down Expand Up @@ -42,25 +42,16 @@ const getDefaultConfigFiles = () => {
};

const getConfigInfoFromFileName = (filename) => {
const fileMetaData = parse(filename);
// .cjs is not available on interpret side, handle it manually for now
if (filename.endsWith('.cjs')) {
return [
{
path: resolve(filename),
ext: '.cjs',
module: null,
},
];
}
return Object.keys(extensions)
.filter((ext) => ext.includes(fileMetaData.ext))
.filter((ext) => fileMetaData.base.substr(fileMetaData.base.length - ext.length) === ext)
.map((ext) => {
const ext = extname(filename);
// since we support only one config for now
const allFiles = [filename];
// return all the file metadata
return allFiles
.map((file) => {
return {
path: resolve(filename),
path: resolve(file),
ext: ext,
module: extensions[ext],
module: extensions[ext] || null,
};
})
.filter((e) => existsSync(e.path));
Expand Down