Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add commitlint github action #1766

Merged
merged 8 commits into from
Sep 1, 2020
Merged

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Aug 25, 2020

What kind of change does this PR introduce?
chore

Did you add tests for your changes?
NA
If relevant, did you update the documentation?
NA
Summary

added commitlint action

Does this PR introduce a breaking change?
No

Other information
No

@snitin315 snitin315 force-pushed the chore/commitlint-action branch 2 times, most recently from ac9a776 to 9a56cf5 Compare August 25, 2020 11:15
@snitin315 snitin315 marked this pull request as ready for review August 25, 2020 11:32
@snitin315 snitin315 requested a review from a team as a code owner August 25, 2020 11:32
evenstensberg
evenstensberg previously approved these changes Aug 25, 2020
Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't seem to find the job running?

@snitin315
Copy link
Member Author

Hmm, something is wrong. Looking into it.

Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you haven't specified enough information
https://github.com/wagoid/commitlint-github-action#usage

Copy link
Member

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion on next steps.

.github/workflows/nodejs.yml Show resolved Hide resolved
@webpack-bot
Copy link

@snitin315 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@rishabh3112 Please review the new changes.

@snitin315
Copy link
Member Author

It's failing 😞

@alexander-akait
Copy link
Member

Need fix CI

@snitin315
Copy link
Member Author

😕 ❓
Screenshot at 2020-08-27 14-13-16

@snitin315
Copy link
Member Author

CI is failing for webpack@next due to the new release. I will send a fix soon. WIP.

@snitin315 snitin315 merged commit 9d54742 into next Sep 1, 2020
@snitin315 snitin315 deleted the chore/commitlint-action branch September 1, 2020 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants