Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add necessary peerDependencies #1825

Merged
merged 5 commits into from
Sep 29, 2020
Merged

Conversation

ylemkimon
Copy link
Contributor

@ylemkimon ylemkimon commented Sep 23, 2020

What kind of change does this PR introduce?
Bugfix

Did you add tests for your changes?
N/A

If relevant, did you update the documentation?
N/A

Summary
This PR adds webpack and webpack-cli peerDependencies to packages requiring @webpack-cli/utils, which has:

"peerDependencies": {
"webpack": "4.x.x || 5.x.x",
"webpack-cli": "4.x.x || 5.x.x"

Dependency tree (D: dependency, P: peer dependency, *: added in this PR, **: reason):

webpack-cli
├─D> @webpack-cli/package-utils
├─D> @webpack-cli/info
│    └─P> webpack-cli
├─D> @webpack-cli/init
│    ├─P> webpack*
│    ├─P> webpack-cli*
│    ├─D> @webpack-cli/generators
│    │    ├─P> webpack*
│    │    ├─P> webpack-cli*,**
│    │    ├─D> @webpack-cli/package-utils
│    │    ├─D> @webpack-cli/utils
│    │    │    ├─P> webpack**
│    │    │    ├─P> webpack-cli**
│    │    │    └─D> @webpack-cli/package-utils
│    │    └─D> @webpack-cli/webpack-scaffold
│    └─D> @webpack-cli/utils
│         ├─P> webpack**
│         ├─P> webpack-cli**
│         └─D> @webpack-cli/package-utils
└─D> @webpack-cli/serve
     └─P> webpack-cli

Does this PR introduce a breaking change?
No

@ylemkimon ylemkimon requested a review from a team as a code owner September 23, 2020 21:02
@ylemkimon ylemkimon marked this pull request as draft September 23, 2020 21:06
@ylemkimon ylemkimon changed the title fix(generators): add webpack-cli@5.x.x to peerDependencies fix: add necessary peerDependencies Sep 23, 2020
@ylemkimon ylemkimon marked this pull request as ready for review September 23, 2020 21:11
@ylemkimon ylemkimon marked this pull request as draft September 23, 2020 21:37
@ylemkimon ylemkimon marked this pull request as ready for review September 23, 2020 21:38
@ylemkimon

This comment has been minimized.

@ylemkimon ylemkimon marked this pull request as draft September 25, 2020 16:22
@ylemkimon ylemkimon marked this pull request as ready for review September 25, 2020 16:28
@webpack-bot
Copy link

@evilebottnawi Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@anshumanv Please review the new changes.

@rishabh3112
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants