-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add necessary peerDependencies #1825
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylemkimon
changed the title
fix(generators): add webpack-cli@5.x.x to peerDependencies
fix: add necessary peerDependencies
Sep 23, 2020
This comment has been minimized.
This comment has been minimized.
alexander-akait
approved these changes
Sep 25, 2020
anshumanv
approved these changes
Sep 28, 2020
@evilebottnawi Thanks for your update. I labeled the Pull Request so reviewers will review it again. @anshumanv Please review the new changes. |
rishabh3112
approved these changes
Sep 29, 2020
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix
Did you add tests for your changes?
N/A
If relevant, did you update the documentation?
N/A
Summary
This PR adds
webpack
andwebpack-cli
peerDependencies to packages requiring@webpack-cli/utils
, which has:webpack-cli/packages/utils/package.json
Lines 23 to 25 in 134c77a
Dependency tree (D: dependency, P: peer dependency, *: added in this PR, **: reason):
Does this PR introduce a breaking change?
No