Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: check for proper exit code #2025

Merged
merged 13 commits into from
Nov 4, 2020
Merged

tests: check for proper exit code #2025

merged 13 commits into from
Nov 4, 2020

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?
tests

Did you add tests for your changes?
yes
If relevant, did you update the documentation?
no
Summary

Check for proper exit codes.

Does this PR introduce a breaking change?
No

Other information
No

@snitin315 snitin315 marked this pull request as ready for review November 4, 2020 09:46
@snitin315 snitin315 requested a review from a team as a code owner November 4, 2020 09:46
@snitin315
Copy link
Member Author

/cc @webpack/cli-team

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, we should always check exit code

@alexander-akait
Copy link
Member

/cc @webpack/cli-team

Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@snitin315 snitin315 merged commit f4a72c5 into master Nov 4, 2020
@snitin315 snitin315 deleted the tests/exit-code branch November 4, 2020 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants