-
-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: check for proper exit code #2025
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
force-pushed
the
tests/exit-code
branch
from
November 3, 2020 08:46
7119928
to
03f2104
Compare
snitin315
force-pushed
the
tests/exit-code
branch
from
November 4, 2020 04:33
3268177
to
30d0b68
Compare
snitin315
force-pushed
the
tests/exit-code
branch
from
November 4, 2020 06:03
60678e7
to
e4b4850
Compare
snitin315
force-pushed
the
tests/exit-code
branch
from
November 4, 2020 07:04
e4b4850
to
79de9d7
Compare
/cc @webpack/cli-team |
alexander-akait
approved these changes
Nov 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, we should always check exit code
/cc @webpack/cli-team |
anshumanv
approved these changes
Nov 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌟
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
tests
Did you add tests for your changes?
yes
If relevant, did you update the documentation?
no
Summary
Check for proper exit codes.
Does this PR introduce a breaking change?
No
Other information
No