build: do not install webpack 5 again #2417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2417 +/- ##
=======================================
Coverage 71.79% 71.79%
=======================================
Files 47 47
Lines 2177 2177
Branches 574 574
=======================================
Hits 1563 1563
Misses 614 614 Continue to review full report at Codecov.
|
snitin315
force-pushed
the
chore/ci-webpack
branch
from
7938aac
to
1e316e4
Compare
snitin315
force-pushed
the
chore/ci-webpack
branch
2 times, most recently
from
a73c287
to
416a2f1
Compare
snitin315
force-pushed
the
chore/ci-webpack
branch
from
416a2f1
to
43e6d5a
Compare
alexander-akait
approved these changes
Feb 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
build, chore
Did you add tests for your changes?
No
If relevant, did you update the documentation?
No
Summary
webpack-5 is already installed with the dependencies installation step.
Does this PR introduce a breaking change?
No
Other information
No