Refactor test #2632
Merged
Refactor test #2632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
force-pushed
the
refactor-test
branch
from
b02a8e9
to
2ce5f17
Compare
Codecov Report
@@ Coverage Diff @@
## master #2632 +/- ##
==========================================
- Coverage 95.21% 95.14% -0.07%
==========================================
Files 30 30
Lines 1505 1505
Branches 430 430
==========================================
- Hits 1433 1432 -1
- Misses 72 73 +1
Continue to review full report at Codecov.
|
alexander-akait
force-pushed
the
refactor-test
branch
from
825f2d9
to
f37cca2
Compare
snitin315
previously approved these changes
Apr 16, 2021
|
We need search way to say |
|
can you clarify? |
|
https://github.com/tj/commander.js/blob/master/index.js#L577 in our tests on some os we have |
alexander-akait
force-pushed
the
refactor-test
branch
from
1099f9c
to
464fcc4
Compare
alexander-akait
commented
Apr 20, 2021
| @@ -1023,7 +1023,7 @@ class WebpackCLI { | |||
| }, | |||
| formatHelp: (command, helper) => { | |||
| const termWidth = helper.padWidth(command, helper); | |||
| const helpWidth = helper.helpWidth || 80; | |||
| const helpWidth = helper.helpWidth || process.env.WEBPACK_CLI_HELP_WIDTH || 80; | |||
There was a problem hiding this comment.
For testing purpose and for edge case where developer can set width of TTY
|
Finally, I'll do a couple PRs for tests, improve them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactor/tests
Did you add tests for your changes?
it is tests
If relevant, did you update the documentation?
No need
Summary
Part of #2573 to avoid big changes
Does this PR introduce a breaking change?
No
Other information
In future we should migrate on stdout and stderr snapshot tests everywhere, so feel free to send PRs with improve it, better do it by command, for
buildcommand by group of options,serveno need touch right now WIP on this