Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(addon-generator): add prompt to select a package manager of choice #2779

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

jamesgeorge007
Copy link
Member

What kind of change does this PR introduce?
Feature

Did you add tests for your changes?
Update test suite

If relevant, did you update the documentation?
N/A

Summary
closes #2768

Does this PR introduce a breaking change?
No

Other information
N/A

@jamesgeorge007 jamesgeorge007 requested a review from a team as a code owner June 9, 2021 18:17
Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #2779 (9bbc71d) into master (e53f164) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2779   +/-   ##
=======================================
  Coverage   94.05%   94.05%           
=======================================
  Files          32       32           
  Lines        1698     1699    +1     
  Branches      491      490    -1     
=======================================
+ Hits         1597     1598    +1     
  Misses        101      101           
Impacted Files Coverage Δ
packages/generators/src/addon-generator.ts 91.52% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e53f164...9bbc71d. Read the comment docs.

@alexander-akait alexander-akait merged commit 5bd0df4 into master Jun 10, 2021
@alexander-akait alexander-akait deleted the feat/addon-generator branch June 10, 2021 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the ability to pick a package manager of choice while scaffolding
6 participants