Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update webpack-dev-server usage #2853

Merged
merged 1 commit into from
Jul 24, 2021
Merged

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Jul 24, 2021

What kind of change does this PR introduce?
fix

Did you add tests for your changes?
Already present
If relevant, did you update the documentation?
No
Summary

Use the latest API, otherwise npx webpack serve will show a deprecation warning like:

Screenshot 2021-07-24 at 9 49 30 AM

Does this PR introduce a breaking change?
No

Other information
No

@codecov
Copy link

codecov bot commented Jul 24, 2021

Codecov Report

Merging #2853 (6159360) into master (6bb6b7d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2853   +/-   ##
=======================================
  Coverage   95.01%   95.01%           
=======================================
  Files          31       31           
  Lines        1704     1706    +2     
  Branches      496      497    +1     
=======================================
+ Hits         1619     1621    +2     
  Misses         85       85           
Impacted Files Coverage Δ
packages/serve/src/index.ts 84.37% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53622dc...6159360. Read the comment docs.

@alexander-akait alexander-akait merged commit d9d4c37 into master Jul 24, 2021
@alexander-akait alexander-akait deleted the update-dev-server-usage branch July 24, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants