Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: using new dev server API for v4 #2886

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

alexander-akait
Copy link
Member

What kind of change does this PR introduce?

bugfix

Did you add tests for your changes?

existing

If relevant, did you update the documentation?

No need

Summary

due webpack/webpack-dev-server#3608

Does this PR introduce a breaking change?

No

Other information

No

@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #2886 (9642c17) into master (1a337aa) will decrease coverage by 0.10%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2886      +/-   ##
==========================================
- Coverage   94.95%   94.84%   -0.11%     
==========================================
  Files          31       31              
  Lines        1704     1708       +4     
  Branches      484      486       +2     
==========================================
+ Hits         1618     1620       +2     
- Misses         86       88       +2     
Impacted Files Coverage Δ
packages/serve/src/index.ts 83.53% <62.50%> (-0.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a337aa...9642c17. Read the comment docs.

@alexander-akait alexander-akait merged commit f66d01f into master Aug 13, 2021
@alexander-akait alexander-akait deleted the fix-using-new-dev-server-api-for-v4 branch August 13, 2021 13:05
anshumanv pushed a commit that referenced this pull request Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants