chore: upgrade all dependencies, devDependencies #290

dhruvdutt · 2018-02-26T16:52:44Z

What kind of change does this PR introduce?
Feature/Upgrade

Did you add tests for your changes?
Updated migrate snapshot (031b798)

Summary

Upgrades all dependencies, devDependencies to latest except yargs*. 🚀
Update supports-color usage to resolve breaking changes
Remove unused devDependencies: flow-bin, flow-remove-types
Drops support for Node.js v4, going forward we only support v6+ (same as webpack-dev-server >= 3.0.0 and webpack >= 4.0.0)
- Other dependencies that dropped Node.js v4 support:
  - cross-spawn >= 6.0.0
  - inquirer >= 4.0.0

*We will need to doublecheck on yargs changelog for breaking changes in version 10.0.0 and 11.0.0

Does this PR introduce a breaking change?
No

ematipico · 2018-02-26T17:10:47Z

package.json

-    "eslint-plugin-node": "^5.1.0",
-    "flow-bin": "^0.49.1",
+    "eslint-plugin-node": "^6.0.1",
+    "flow-bin": "^0.66.0",


You can remove flow-bin, it's not used anymore

ematipico · 2018-02-26T17:13:36Z

I think you should rebase from master. We removed the job that was causing this problem with the CI. (https://github.com/webpack/webpack-cli/pull/277/files#r170428216)

ematipico · 2018-02-26T17:23:51Z

package.json

@@ -123,7 +123,6 @@
    "cz-customizable": "^5.2.0",
    "eslint": "^4.2.0",
    "eslint-plugin-node": "^6.0.1",
-    "flow-bin": "^0.66.0",
    "flow-remove-types": "^1.2.1",


Sorry to bother again! Just noticed that we can also remove flow-remove-types!

Ah! No worries. I just ran npm-check to check for all unused deps and this is the list of unused deps returned in output:

Can you please confirm which ones to keep/remove?

global
recast
uglifyjs-webpack-plugin
@commitlint/cli
@commitlint/prompt-cli
commitizen
conventional-changelog-lint-config-cz
husky
lint-staged
schema-utils

No one here

I've cleaned flow-bin, flow-remove-types as suggested by @ematipico
Also, updated PR description.

evenstensberg

Gotta double check the colors thing, do not update yargs, as there's a security volun on the new version.

dhruvdutt · 2018-02-26T20:04:26Z

@ev1stensberg Reverted back to "yargs": "9.0.1" and added a note about it in PR description.

evenstensberg · 2018-02-27T18:12:05Z

bin/webpack.js

@@ -318,7 +318,7 @@
 			});

 			if (typeof outputOptions.colors === "undefined")
-				outputOptions.colors = require("supports-color");
+				outputOptions.colors = require("supports-color").stdout;


Anything changed in a newer version?

Doesn't look like anything changed relevant to us other than the API.
There are no changelogs or release notes but you can take a look at this PR #64.

Remove the stdout and you're good. Doesn't work with it

evenstensberg · 2018-03-01T14:45:28Z

bin/webpack.js

@@ -318,7 +318,7 @@
 			});

 			if (typeof outputOptions.colors === "undefined")
-				outputOptions.colors = require("supports-color");
+				outputOptions.colors = require("supports-color").stdout;


Remove the stdout and you're good. Doesn't work with it

webpack-bot · 2018-03-01T15:01:12Z

@dhruvdutt Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@ev1stensberg Please review the new changes.

evenstensberg

Need another reviewer to lgtm this, it's a big change, might break some parts we don't test

evenstensberg · 2018-03-01T15:28:32Z

rebase against master

webpack-bot · 2018-03-01T17:44:11Z

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

dhruvdutt · 2018-03-01T17:45:38Z

Already rebased.

All tests basically fail with this error: (Check expected and contain values)

It should match but it doesn't. Most likely there's some weird issue that ANSI terminal color codes aren't parsed due to some reason when the tests run. Check the screenshot below. Printing stdout like:

console.log(stdout[5]);
console.log(stdout);

However this doesn't happen when we add stdout in supports-color usage.

require("supports-color").stdout

There are no changelogs for supports-color versions but we can go through the latest docs.

Currently added stdout back to supports-color.
LMK if we have some other fix or missing something.

evenstensberg · 2018-03-01T20:29:02Z

Conflicts

dhruvdutt · 2018-03-01T20:49:34Z

@ev1stensberg Resolved. 💯

evenstensberg · 2018-03-01T22:31:34Z

bin/process-options.js

@@ -37,7 +37,7 @@ module.exports = function processOptions(yargs, argv) {
 	});

 	if (typeof outputOptions.colors === "undefined")
-		outputOptions.colors = require("supports-color");
+		outputOptions.colors = require("supports-color").stdout;


No stdout here

evenstensberg · 2018-03-01T22:31:41Z

bin/webpack.js

@@ -318,7 +318,7 @@
 			});

 			if (typeof outputOptions.colors === "undefined")
-				outputOptions.colors = require("supports-color");
+				outputOptions.colors = require("supports-color").stdout;


No stdout here

Removing this breaks the tests. Did you read my above comment?
Do we want the tests to fail?

I want colors to work as intended. If the tests are failing you gotta fix em 👩‍💻✌️

Coolio. So, in that case we can use something like ansi-parser to parse stdout inside tests. WDYT?

Remove the stdout and lemme have a look

Done. You're up captain. 💂‍♂️

evenstensberg · 2018-03-01T22:31:49Z

bin/webpack.js

@@ -80,7 +80,7 @@
 			type: "boolean",
 			alias: "colors",
 			default: function supportsColor() {
-				return require("supports-color");
+				return require("supports-color").stdout;


webpack-bot added PR: unreviewed PR: CI-not-ok labels Feb 26, 2018

ematipico reviewed Feb 26, 2018

View reviewed changes

evenstensberg reviewed Feb 26, 2018

View reviewed changes

dhruvdutt force-pushed the upgrade/deps branch from c1824f1 to c4ff478 Compare February 26, 2018 19:58

dhruvdutt changed the title ~~Upgrade all dependencies, devDependencies~~ chore: upgrade all dependencies, devDependencies Feb 26, 2018

dhruvdutt force-pushed the upgrade/deps branch 3 times, most recently from 31706f4 to fbc645d Compare February 27, 2018 10:36

webpack-bot added PR: CI-ok and removed PR: CI-not-ok labels Feb 27, 2018

evenstensberg reviewed Feb 27, 2018

View reviewed changes

evenstensberg requested changes Mar 1, 2018

View reviewed changes

webpack-bot added PR: reviewed-changes-requested PR: review-outdated and removed PR: unreviewed PR: reviewed-changes-requested labels Mar 1, 2018

evenstensberg approved these changes Mar 1, 2018

View reviewed changes

webpack-bot added PR: reviewed-approved PR: CI-not-ok and removed PR: review-outdated PR: CI-ok labels Mar 1, 2018

dhruvdutt added 3 commits March 1, 2018 20:59

chore(upgrade): update all dependencies, devDependencies

4bf64bf

chore(refactor): update supports-color usage

97b2df3

tests(update): migrate snapshot

c322067

dhruvdutt added 5 commits March 1, 2018 20:59

misc(syntax): prettify

5cb146f

chore(clean): remove unused dependency

4a395d7

chore(revert): revert yargs to 9.0.1

7ef13ef

misc(revert): revert supports-color usage

75f706b

tests(update): migrate snapshot

3c4e6f7

dhruvdutt force-pushed the upgrade/deps branch from 2f0fdf4 to 3c4e6f7 Compare March 1, 2018 17:28

webpack-bot added PR: review-outdated and removed PR: reviewed-approved labels Mar 1, 2018

chore(refactor): update supports-color usage

4566fde

webpack-bot added PR: CI-ok and removed PR: CI-not-ok labels Mar 1, 2018

misc(conflicts): resolve conflicts

a8213af

evenstensberg requested changes Mar 1, 2018

View reviewed changes

webpack-bot added PR: reviewed-changes-requested and removed PR: review-outdated labels Mar 1, 2018

misc(revert): revert supports-color usage

f8e819a

webpack-bot added PR: review-outdated and removed PR: reviewed-changes-requested labels Mar 1, 2018

evenstensberg merged commit f8e819a into webpack:master Mar 1, 2018

dhruvdutt mentioned this pull request Mar 4, 2018

Unpin dependencies where possible #307

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: upgrade all dependencies, devDependencies #290

chore: upgrade all dependencies, devDependencies #290

dhruvdutt commented Feb 26, 2018 •

edited

Loading

ematipico Feb 26, 2018

ematipico commented Feb 26, 2018

ematipico Feb 26, 2018

dhruvdutt Feb 26, 2018 •

edited

Loading

evenstensberg Feb 26, 2018

dhruvdutt Feb 26, 2018 •

edited

Loading

evenstensberg left a comment

dhruvdutt commented Feb 26, 2018 •

edited

Loading

evenstensberg Feb 27, 2018

dhruvdutt Feb 27, 2018

evenstensberg Mar 1, 2018

evenstensberg Mar 1, 2018

webpack-bot commented Mar 1, 2018

evenstensberg left a comment

evenstensberg commented Mar 1, 2018

webpack-bot commented Mar 1, 2018

dhruvdutt commented Mar 1, 2018

evenstensberg commented Mar 1, 2018

dhruvdutt commented Mar 1, 2018

evenstensberg Mar 1, 2018

evenstensberg Mar 1, 2018

dhruvdutt Mar 1, 2018

evenstensberg Mar 1, 2018

dhruvdutt Mar 1, 2018 •

edited

Loading

evenstensberg Mar 1, 2018

dhruvdutt Mar 1, 2018

evenstensberg Mar 1, 2018

chore: upgrade all dependencies, devDependencies #290

chore: upgrade all dependencies, devDependencies #290

Conversation

dhruvdutt commented Feb 26, 2018 • edited Loading

Choose a reason for hiding this comment

ematipico commented Feb 26, 2018

Choose a reason for hiding this comment

dhruvdutt Feb 26, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dhruvdutt Feb 26, 2018 • edited Loading

Choose a reason for hiding this comment

evenstensberg left a comment

Choose a reason for hiding this comment

dhruvdutt commented Feb 26, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

webpack-bot commented Mar 1, 2018

evenstensberg left a comment

Choose a reason for hiding this comment

evenstensberg commented Mar 1, 2018

webpack-bot commented Mar 1, 2018

dhruvdutt commented Mar 1, 2018

evenstensberg commented Mar 1, 2018

dhruvdutt commented Mar 1, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dhruvdutt Mar 1, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dhruvdutt commented Feb 26, 2018 •

edited

Loading

dhruvdutt Feb 26, 2018 •

edited

Loading

dhruvdutt Feb 26, 2018 •

edited

Loading

dhruvdutt commented Feb 26, 2018 •

edited

Loading

dhruvdutt Mar 1, 2018 •

edited

Loading