Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(info): rename --additional-package flag to additional-packages #3019

Closed
wants to merge 1 commit into from

Conversation

jamesgeorge007
Copy link
Member

What kind of change does this PR introduce?
chore

Did you add tests for your changes?
Update test suite.

If relevant, did you update the documentation?
Yes

Summary
Rename --additional-package to --additional-packages as it supports variadic arguments.

Does this PR introduce a breaking change?
Yes, --additional-package is not recognized anymore.

Other information
N/A

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 30, 2021

CLA Signed

The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Oct 30, 2021

Codecov Report

Merging #3019 (b7829bc) into master (962ab79) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3019      +/-   ##
==========================================
- Coverage   94.89%   94.86%   -0.04%     
==========================================
  Files          22       22              
  Lines        1625     1615      -10     
  Branches      482      480       -2     
==========================================
- Hits         1542     1532      -10     
  Misses         83       83              
Impacted Files Coverage Δ
packages/info/src/index.ts 100.00% <100.00%> (ø)
packages/webpack-cli/bin/cli.js 85.71% <0.00%> (-4.29%) ⬇️
packages/webpack-cli/lib/webpack-cli.js 95.68% <0.00%> (-0.03%) ⬇️
packages/webpack-cli/lib/bootstrap.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 962ab79...b7829bc. Read the comment docs.

@alexander-akait
Copy link
Member

Sorry for delay, not sure we need it, because we have --entry=foo.js --entry=bar.js and there are a lot of other options with the same logic in names, so let's keep it as it and avoid breaking changes, I would say that this is our design, sorry for losing your time and feel free to feedback

@alexander-akait alexander-akait deleted the info-additional-packages branch April 29, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants