Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update lerna to v6 #3457

Merged
merged 1 commit into from
Oct 19, 2022
Merged

chore: update lerna to v6 #3457

merged 1 commit into from
Oct 19, 2022

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?
deps update

Did you add tests for your changes?
No.

If relevant, did you update the documentation?

Summary

Fix #3448

Does this PR introduce a breaking change?
No

Other information
No

@snitin315 snitin315 requested a review from a team as a code owner October 19, 2022 02:02
@snitin315 snitin315 changed the base branch from master to next October 19, 2022 02:02
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #3457 (d1d51c3) into next (0f7da89) will increase coverage by 20.76%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             next    #3457       +/-   ##
===========================================
+ Coverage   70.53%   91.30%   +20.76%     
===========================================
  Files          21       22        +1     
  Lines        1585     1587        +2     
  Branches      447      447               
===========================================
+ Hits         1118     1449      +331     
+ Misses        467      138      -329     
Impacted Files Coverage Δ
packages/generators/addon-template/package.json.js 100.00% <0.00%> (ø)
packages/serve/src/index.ts 78.94% <0.00%> (+4.38%) ⬆️
packages/configtest/src/index.ts 96.00% <0.00%> (+12.00%) ⬆️
packages/webpack-cli/src/plugins/CLIPlugin.ts 100.00% <0.00%> (+14.54%) ⬆️
packages/webpack-cli/src/webpack-cli.ts 92.69% <0.00%> (+18.06%) ⬆️
packages/webpack-cli/src/bootstrap.ts 100.00% <0.00%> (+25.00%) ⬆️
packages/generators/src/plugin-generator.ts 100.00% <0.00%> (+28.57%) ⬆️
packages/generators/src/utils/scaffold-utils.ts 100.00% <0.00%> (+37.50%) ⬆️
packages/generators/src/loader-generator.ts 91.66% <0.00%> (+41.66%) ⬆️
packages/generators/src/index.ts 86.36% <0.00%> (+43.18%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f7da89...d1d51c3. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snitin315 Any critical breaking changes for us?

@snitin315
Copy link
Member Author

@alexander-akait No, we are good. In v5 they dropped node 12 support and in v6 they updated some defaults.

@alexander-akait
Copy link
Member

@snitin315 Feel free to emrge when CI will be green 👍

@snitin315 snitin315 merged commit 4340070 into next Oct 19, 2022
@snitin315 snitin315 deleted the update-lerna branch October 19, 2022 15:44
snitin315 added a commit that referenced this pull request Oct 22, 2022
snitin315 added a commit that referenced this pull request Nov 6, 2022
snitin315 added a commit that referenced this pull request Nov 8, 2022
alexander-akait pushed a commit that referenced this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants