fix: support .cts and .mts
#3831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3831 +/- ##
==========================================
- Coverage 91.64% 91.42% -0.23%
==========================================
Files 22 22
Lines 1628 1667 +39
Branches 466 480 +14
==========================================
+ Hits 1492 1524 +32
- Misses 136 143 +7
Continue to review full report in Codecov by Sentry.
|
|
And I really hope we will not have |
alexander-akait
commented
Jun 3, 2023
| } | ||
| break; | ||
| } | ||
| case "esm": { |
There was a problem hiding this comment.
Avoid extra require for esm (i.e. mts and mjs)
alexander-akait
commented
Jun 3, 2023
| @@ -1,7 +1,7 @@ | |||
| path = require 'path' | |||
|
|
|||
| config = | |||
| mode: 'production' | |||
| mode: 'development' | |||
alexander-akait
commented
Jun 3, 2023
| ".webpack/webpack.config", | ||
| ".webpack/webpackfile", | ||
| ].flatMap((filename) => extensions.map((ext) => path.resolve(filename + ext))); | ||
| const defaultConfigFiles = new Set( |
There was a problem hiding this comment.
To avoid duplicates
|
the current method seems good enough for normal use case and we're going to support this as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some magic:
.ctsand.mts.mtsis still have hacky support -NODE_OPTIONS="--loader ts-node/esm" webpack-cli --config ./webpack.config.mts.ctsworks fine.tsworks out of box forCommonJS, but need a hack from above for.mts.mtsto avoid using extrarequire@hardfist there is basic support for
.ctsand.mts(.tsalready supported), no problems withcommonjs, butesmusing is still hacky duerechoirdoesn't supportESMhooks for Node.js (because Node.js changed it multiple times recently and it is still not stable).What kind of change does this PR introduce?
I want to say it is a
bugfixDid you add tests for your changes?
Soon
If relevant, did you update the documentation?
No need
Summary
Better support typescript configurations
Does this PR introduce a breaking change?
No
Other information
No