Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: the minimum required Node.js version is 18.12.0 #4062

Merged
merged 2 commits into from Jan 22, 2024

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?
build

Did you add tests for your changes?
No

If relevant, did you update the documentation?
No

Summary

The minimum required Node.js version is 18.12.0

Does this PR introduce a breaking change?
Yes

Other information
No

@snitin315 snitin315 requested a review from a team as a code owner January 21, 2024 04:26
@snitin315 snitin315 changed the base branch from master to next January 21, 2024 04:26
Copy link

codecov bot commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7817b6e) 90.59% compared to head (04e1bba) 90.59%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #4062   +/-   ##
=======================================
  Coverage   90.59%   90.59%           
=======================================
  Files          22       22           
  Lines        1702     1702           
  Branches      491      491           
=======================================
  Hits         1542     1542           
  Misses        160      160           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7817b6e...04e1bba. Read the comment docs.

@alexander-akait
Copy link
Member

Do you want to work in the one PR? Or split it on differents PRs into the next?

Anyway thank you

@snitin315
Copy link
Member Author

I will split in different PRs on next

@alexander-akait alexander-akait merged commit ef845c4 into next Jan 22, 2024
32 checks passed
@alexander-akait alexander-akait deleted the drop-node-16 branch January 22, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants