cli(prompts): Add autocomplete support for config props #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ematipico
reviewed
Jun 12, 2018
packages/generators/add-generator.js
Outdated
| const Confirm = require("@webpack-cli/webpack-scaffold").Confirm; | ||
| const List = require("@webpack-cli/webpack-scaffold").List; | ||
| const Input = require("@webpack-cli/webpack-scaffold").Input; | ||
| const AutoComplete = require("@webpack-cli/webpack-scaffold").AutoComplete; |
There was a problem hiding this comment.
Trivial: at this point we could refactor with destructoring
const { Confirm, List, Input, AutoComplete }= require("@webpack-cli/webpack-scaffold")
ematipico
reviewed
Jun 12, 2018
| @@ -14,6 +16,8 @@ const getPackageManager = require("@webpack-cli/utils/package-manager") | |||
| const npmExists = require("@webpack-cli/utils/npm-exists"); | |||
| const entryQuestions = require("./utils/entry"); | |||
|
|
|||
| const PROPS = Array.from(PROP_TYPES.keys()); | |||
There was a problem hiding this comment.
.keys already returns an array. Why did you use Array.from?
There was a problem hiding this comment.
When using a Set, it returns an Iterator instead of array. Hence, we have to use Array.from method.
In case of object, .keys returns an array.
There was a problem hiding this comment.
Aaah it was a Set! Fair enough, thanks!
ematipico
reviewed
Jun 12, 2018
packages/generators/add-generator.js
Outdated
| */ | ||
| const searchProps = (answers, input) => { | ||
| input = input || ""; | ||
| return new Promise(resolve => { |
There was a problem hiding this comment.
Just a suggestion:
return Promise.resolve(
PROPS.filter(food =>
food.toLowerCase().includes(input.toLowerCase())
)
)
ematipico
approved these changes
Jun 12, 2018
This comment has been minimized.
This comment has been minimized.
ematipico
suggested changes
Jun 13, 2018
packages/generators/add-generator.js
Outdated
| ) | ||
| ); | ||
| }); | ||
| return new Promise.resolve( |
webpack-bot
added
PR: reviewed-changes-requested
and removed
PR: review-outdated
labels
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
evenstensberg
approved these changes
Jun 13, 2018
evenstensberg
changed the title
|
Yes. I'll start with TS. 🎉 |
ematipico
approved these changes
Jun 13, 2018
|
🎉 This PR is included in version 3.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
Other information