feat(typescript): setup base infra #511

dhruvdutt · 2018-06-14T19:54:33Z

What kind of change does this PR introduce?
Feature

Did you add tests for your changes?

If relevant, did you update the documentation?

Summary
Add initial TypeScript support for @webpack-cli/init package.
Use npm run build and npm run watch for dev.

Does this PR introduce a breaking change?

Other information
#245

dhruvdutt · 2018-06-14T19:56:09Z

packages/init/init.ts

@@ -16,12 +16,12 @@ const propTypes = require("@webpack-cli/utils/prop-types");
 *
 * @param	{Object} transformObject 	- An Object with all transformations
 * @param	{Object} config 			- Configuration to transform
- * @returns {Object} - An Object with the transformations to be run
+ * @returns {Array} - An array with the transformations to be run


A bug in our docs caught by TypeScript. 😅

dhruvdutt · 2018-06-14T19:59:22Z

packages/init/init.ts

@@ -33,37 +33,38 @@ function mapOptionsToTransform(config) {
 * and writes the file
 */

-module.exports = function runTransform(webpackProperties, action) {
+export default function runTransform(webpackProperties, action: string) {


This could be also done like (webpackProperties: any, action: string): any. I prefer not to bloat code with any.

If we don't want to use any, then we can explicitly define interface/type of whole webpackProperties object.

use any here, it's fine.

We should avoid the use of any. Maybe we can leave a TODO to come back later once we have the interface. any is evil, it makes the use of a type checker basically pointless.

evenstensberg · 2018-06-14T20:11:06Z

Before you do anything else, could you create a new next branch and target your PR towards that? I think this is the point where we need to actively do that

dhruvdutt · 2018-06-14T20:25:42Z

By "new next branch", did you mean changing the base branch to next? What should be the base branch?

Currently, I've pushed the code to typescript branch on the current repo.

evenstensberg · 2018-06-14T20:46:25Z

master is base branch but next is develop branch

evenstensberg

Taking this review in stages. I don't know if we should have the ts configs at webpack-cli or within each package. To avoid dupe code maybe its better to have it at the top scope (webpack-cli)?

evenstensberg

Also create the root package.json compilation. The build step should be done in "prepare" and publish after compilation. It should not include the ts files for each package.

evenstensberg · 2018-06-15T07:06:01Z

packages/init/init.ts

@@ -33,37 +33,38 @@ function mapOptionsToTransform(config) {
 * and writes the file
 */

-module.exports = function runTransform(webpackProperties, action) {
+export default function runTransform(webpackProperties, action: string) {


use any here, it's fine.

evenstensberg · 2018-06-15T07:06:50Z

packages/init/tsconfig.json

@@ -0,0 +1,14 @@
+{
+  "compilerOptions": {
+    // Targeted standard


uncomment, invalid styntax and unneeded

ematipico · 2018-06-15T08:13:39Z

packages/init/index.ts

 * packages included when running the init command
 * @returns	{Function}	creator/npmPackagesExists - returns an installation of the package,
 * followed up with a yeoman instance of that if there's packages. If not, it creates a defaultGenerator
 */

-module.exports = function initializeInquirer(...args) {
-	const packages = args.slice(3);
+export default function initializeInquirer(...args: string[]) {


I personally started to avoid default exports. Named exports are way better on the long run.

EDIT: this is just my personal opinion, we can leave them here

webpack-bot · 2018-06-15T21:25:41Z

@dhruvdutt Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@ev1stensberg Please review the new changes.

evenstensberg · 2018-06-16T13:52:20Z

.gitignore

@@ -33,3 +33,6 @@ lerna-debug.log

 # Yarn lock file
 yarn.lock
+
+# TypeScript generated files
+packages/init/*.js


Should be `/packages/**/*.js

evenstensberg · 2018-06-16T13:52:38Z

packages/init/init.ts

@@ -33,37 +33,38 @@ function mapOptionsToTransform(config) {
 * and writes the file
 */

-module.exports = function runTransform(webpackProperties, action) {
+export default function runTransform(webpackProperties, action: string) {


evenstensberg · 2018-06-17T13:07:16Z

You will need to do a fresh rebase at next branch. It doesn't seem like the next branch has been updated yet. What is the status on that?

evenstensberg · 2018-06-20T02:31:28Z

package.json

    "lint:codeOnly": "eslint \"{bin}/**/!(__testfixtures__)/*.js\" \"{bin}/**.js\"",
+    "lint": "eslint \"./bin/*.js\" \"./test/**/*.js\" \"{packages}/**/!(node_modules)/*.js\" ",


add tslint command as well and hook them up to ci and infra

evenstensberg · 2018-06-20T02:31:47Z

package.json

-    "jsdoc": "jsdoc -c jsdoc.json -r -d docs",
-    "appveyor:lint": "lerna bootstrap && npm run lint",
-    "appveyor:test": "npm run test",
+    "semantic-release": "semantic-release",


this should be removed now. Bad rebase? SR is removed from master

Fixing this. I think next branch will need rebasing as well.

git pull origin master

evenstensberg · 2018-06-20T02:32:15Z

tsconfig.json

+  "exclude": [
+    "node_modules/**",
+    "packages/*/node_modules/**",
+    "**/*.d.ts"


If skipLibCheck is true, it will ignore the sourcemaps

evenstensberg · 2018-06-21T14:43:40Z

This branch has conflicts that you'll need to resolve before going further 👍

dhruvdutt

Looks ready for the final round of review.

dhruvdutt requested a review from evenstensberg June 14, 2018 19:54

webpack-bot added the PR: unreviewed label Jun 14, 2018

dhruvdutt commented Jun 14, 2018

View reviewed changes

dhruvdutt changed the base branch from master to next June 14, 2018 20:18

dhruvdutt force-pushed the typescript branch 2 times, most recently from e883304 to 38ff991 Compare June 14, 2018 20:21

evenstensberg requested changes Jun 14, 2018

View reviewed changes

webpack-bot added PR: reviewed-changes-requested and removed PR: unreviewed labels Jun 14, 2018

evenstensberg requested changes Jun 15, 2018

View reviewed changes

ematipico reviewed Jun 15, 2018

View reviewed changes

dhruvdutt force-pushed the next branch from bf78411 to 398d18f Compare June 15, 2018 21:11

dhruvdutt force-pushed the typescript branch from 38ff991 to 4b4625e Compare June 15, 2018 21:25

webpack-bot added PR: review-outdated and removed PR: reviewed-changes-requested labels Jun 15, 2018

dhruvdutt force-pushed the typescript branch from 4f83750 to 75eba99 Compare June 15, 2018 21:38

evenstensberg requested changes Jun 16, 2018

View reviewed changes

webpack-bot added PR: reviewed-changes-requested and removed PR: review-outdated labels Jun 16, 2018

dhruvdutt force-pushed the next branch from 3ac65a9 to 888a67e Compare June 17, 2018 18:40

dhruvdutt force-pushed the typescript branch from 75eba99 to e029049 Compare June 17, 2018 18:51

webpack-bot added PR: review-outdated and removed PR: reviewed-changes-requested labels Jun 17, 2018

dhruvdutt force-pushed the typescript branch from e029049 to baa6284 Compare June 17, 2018 19:58

dhruvdutt changed the title ~~WIP - [init] TypeScript support~~ feat(typescript): setup infra Jun 17, 2018

dhruvdutt changed the title ~~feat(typescript): setup infra~~ feat(typescript): setup base infra Jun 17, 2018

dhruvdutt force-pushed the typescript branch from baa6284 to a567599 Compare June 17, 2018 19:59

dhruvdutt mentioned this pull request Jun 17, 2018

feat(init): add typescript support #518

Merged

dhruvdutt force-pushed the typescript branch 4 times, most recently from 2846cc1 to 72c90e5 Compare June 19, 2018 12:34

evenstensberg requested changes Jun 20, 2018

View reviewed changes

webpack-bot added PR: reviewed-changes-requested and removed PR: review-outdated labels Jun 20, 2018

dhruvdutt force-pushed the typescript branch from 72c90e5 to 56a5bcb Compare June 21, 2018 14:27

webpack-bot added PR: review-outdated and removed PR: reviewed-changes-requested labels Jun 21, 2018

dhruvdutt force-pushed the next branch from 888a67e to 8fd5aba Compare June 21, 2018 14:34

feat(typescript): setup base infra

e105bda

dhruvdutt force-pushed the typescript branch from 56a5bcb to e105bda Compare June 21, 2018 14:40

dhruvdutt commented Jun 21, 2018

View reviewed changes

evenstensberg approved these changes Jun 21, 2018

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: review-outdated labels Jun 21, 2018

dhruvdutt merged commit fe25465 into next Jun 21, 2018

evenstensberg deleted the typescript branch December 22, 2018 09:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(typescript): setup base infra #511

feat(typescript): setup base infra #511

dhruvdutt commented Jun 14, 2018 •

edited

Loading

dhruvdutt Jun 14, 2018

dhruvdutt Jun 14, 2018

evenstensberg Jun 15, 2018

ematipico Jun 15, 2018

evenstensberg Jun 16, 2018

evenstensberg commented Jun 14, 2018

dhruvdutt commented Jun 14, 2018

evenstensberg commented Jun 14, 2018

evenstensberg left a comment

evenstensberg left a comment

evenstensberg Jun 15, 2018

evenstensberg Jun 15, 2018

ematipico Jun 15, 2018 •

edited

Loading

webpack-bot commented Jun 15, 2018

evenstensberg Jun 16, 2018

evenstensberg Jun 16, 2018

evenstensberg commented Jun 17, 2018

evenstensberg Jun 20, 2018

evenstensberg Jun 20, 2018

dhruvdutt Jun 21, 2018

evenstensberg Jun 21, 2018

evenstensberg Jun 20, 2018

evenstensberg commented Jun 21, 2018

dhruvdutt left a comment

		"lint:codeOnly": "eslint \"{bin}/*/!(__testfixtures__)/.js\" \"{bin}/**.js\"",
		"lint": "eslint \"./bin/.js\" \"./test//.js\" \"{packages}/*/!(node_modules)/.js\" ",

feat(typescript): setup base infra #511

feat(typescript): setup base infra #511

Conversation

dhruvdutt commented Jun 14, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

evenstensberg commented Jun 14, 2018

dhruvdutt commented Jun 14, 2018

evenstensberg commented Jun 14, 2018

evenstensberg left a comment

Choose a reason for hiding this comment

evenstensberg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ematipico Jun 15, 2018 • edited Loading

Choose a reason for hiding this comment

webpack-bot commented Jun 15, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

evenstensberg commented Jun 17, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

evenstensberg commented Jun 21, 2018

dhruvdutt left a comment

Choose a reason for hiding this comment

dhruvdutt commented Jun 14, 2018 •

edited

Loading

ematipico Jun 15, 2018 •

edited

Loading