feat(cli): TypeScript support #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* docs(pkg): readme info Created read me file for info sub package * docs(readme): added usage example * Updated usage * Fixed correct package * docs(info): small typo
* docs(pkg): readme info Created read me file for info sub package * docs(readme): added usage example * Updated usage * Fixed correct package * docs(info): small typo
* docs(pkg): readme file for add package * docs(add): fix missing content
There are issues when we import TS compiled JS files into JS because TS compiles default exports to `default` named import/export which makes it not possible to import inside JS directly. Some of the ways to fix this is using .default in all calls or avoid using default export/import totally. Ref: https://basarat.gitbooks.io/typescript/docs/tips/defaultIsBad.html
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
|
Are we ready? 😃 Please update the template. It's an important PR, let's give nice visibility |
evenstensberg
requested changes
Jul 17, 2018
evenstensberg
approved these changes
Jul 18, 2018
dhruvdutt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
Other information
Closes #245