Output lib array opt #562

connorjclark · 2018-08-02T11:41:09Z

Fixes #557

dhruvdutt

Please follow the commit message for commitlint to pass. Use one of these.

Eg. cli: output lib array opt
or
tests(bin): add output options tests

connorjclark · 2018-08-02T19:04:21Z

I just left for vacation and don't have access to my machine. And to be frank, I find the extra hoop here to make a simple contribution to be cumbersome. Is there a simple way within GitHubs workflow that you could make these sorts of (to people outside of the project maintenance mindset, annoying) changes?

ematipico · 2018-08-02T20:07:22Z

Don't worry, we can rewrite the message of the commit while we do the merge onto master!

evenstensberg · 2018-08-05T11:02:14Z

bin/convert-argv.js

@@ -441,7 +441,10 @@ module.exports = function(...args) {

 		ifArg("output-library", function(value) {
 			ensureObject(options, "output");
-			options.output.library = value;
+			if (!options.output.library) {


Default value could be an empty array from yargs

Just tried this, does not work. Default value is not set if a value is given via the CLI - it isn't an initial value. However I did replace this code w/ ensureArray

evenstensberg · 2018-08-05T11:02:31Z

test/binCases/output/output-library-many/stdin.js

+	expect(stdout[7]).toMatch(/index\.js.*\{0\}/);
+	expect(stderr).toHaveLength(0);
+
+	const output = require("fs").readFileSync(require("path").join(__dirname, "../../../js/bin/output/output-library-many/bundle.js"), "utf-8");


import and destruct at top level instead

evenstensberg · 2018-08-05T11:04:41Z

test/binCases/output/output-library-single/test.opts

@@ -0,0 +1,5 @@
+./index.js
+-o ../../../js/bin/output/output-library-single/bundle.js


Don't think this is needed, what's the syntax in the other tests?

removed. only the original output test used this flag, I just copied from there.

webpack-bot · 2018-08-09T21:45:25Z

@hoten Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@ev1stensberg Please review the new changes.

connorjclark · 2018-08-09T21:46:16Z

Addressed comments, pushed changes + squashed to one commit.

connorjclark · 2018-08-09T22:02:23Z

I also wanted a way to quickly run just my tests, so I introduced an env filter for binCases

BIN_TEST_CASES_GREP=output npx jest

webpack-bot · 2018-08-09T22:13:44Z

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

evenstensberg · 2018-08-10T10:00:17Z

test/binCases/output/output-library-single/stdin.js

+	expect(stdout[7]).toMatch(/index\.js.*\{0\}/);
+	expect(stderr).toHaveLength(0);
+
+	const output = fs.readFileSync(path.join(__dirname, "../../../js/bin/output/output-library-single/main.js"), "utf-8");


this should probably be in an own variable

See prev comment 👍

evenstensberg

Had another look, left some comments. Looks smooth so far, just some small fixes and then it's ready! 💯

evenstensberg · 2018-09-01T20:06:27Z

test/binCases/output/output-library-many/stdin.js

+	expect(stdout[7]).toMatch(/index\.js.*\{0\}/);
+	expect(stderr).toHaveLength(0);
+
+	const output = fs.readFileSync(path.join(__dirname, "../../../js/bin/output/output-library-many/main.js"), "utf-8");


could you abstract this a lil better? Quite long line and slashes that could be trimmed down using path.resolve

evenstensberg · 2018-09-01T20:06:46Z

test/binCases/output/output-library-many/stdin.js

+	expect(stderr).toHaveLength(0);
+
+	const output = fs.readFileSync(path.join(__dirname, "../../../js/bin/output/output-library-many/main.js"), "utf-8");
+	expect(output).toContain("window.key1=window.key1||{},window.key1.key2=function");


Maybe match this assertion using the array indice and regexes

evenstensberg · 2018-09-01T20:06:58Z

test/binCases/output/output-library-single/stdin.js

+	expect(stdout[7]).toMatch(/index\.js.*\{0\}/);
+	expect(stderr).toHaveLength(0);
+
+	const output = fs.readFileSync(path.join(__dirname, "../../../js/bin/output/output-library-single/main.js"), "utf-8");


See prev comment 👍

evenstensberg

Small changes left! 💙

evenstensberg · 2018-09-20T10:52:57Z

test/binCases/output/output-library-many/stdin.js

@@ -0,0 +1,14 @@
+"use strict";
+
+const fs = require("fs");


const {readFileSync} = require('fs') const {join} = require('path') const output = readFileSync(join(__dirname, __dirname, "..", "..", ".., "js", "bin", "output", output-library-many", "main.js"), "utf-8")

evenstensberg · 2018-09-20T10:53:54Z

test/binCases/output/output-library-many/stdin.js

+	expect(stderr).toHaveLength(0);
+
+	const output = fs.readFileSync(path.join(__dirname, "../../../js/bin/output/output-library-many/main.js"), "utf-8");
+	expect(output).toContain("window.key1=window.key1||{},window.key1.key2=function");


expect(stdout[myIndices]).toMatch(/window.key1=window.key/*\{0\}/);

evenstensberg · 2018-09-20T10:54:00Z

test/binCases/output/output-library-single/stdin.js

+	expect(stdout[7]).toMatch(/index\.js.*\{0\}/);
+	expect(stderr).toHaveLength(0);
+
+	const output = fs.readFileSync(path.join(__dirname, "../../../js/bin/output/output-library-single/main.js"), "utf-8");


se prev comment

evenstensberg · 2018-09-20T10:54:05Z

test/binCases/output/output-library-single/stdin.js

+	expect(stderr).toHaveLength(0);
+
+	const output = fs.readFileSync(path.join(__dirname, "../../../js/bin/output/output-library-single/main.js"), "utf-8");
+	expect(output).toContain("window.key1=function");


see prev comment

evenstensberg

It's lgtm here, but I think @sokra needs to open up to for webpack internals to use Object.keys(library) and to fetch objects in key-value pairs instead

evenstensberg · 2018-09-29T16:48:18Z

Seems like tests aren't failing. @sokra is this valid?

sokra · 2018-09-29T19:42:35Z

They ain't failing...?

evenstensberg · 2018-09-29T19:45:10Z

Did so locally on mine, but saw the CI afterwards. Was weird..

evenstensberg

tested locally again and it works. Thanks @hoten !! 💙

webpack-bot added PR: unreviewed PR: CI-not-ok labels Aug 2, 2018

dhruvdutt reviewed Aug 2, 2018

View reviewed changes

evenstensberg requested changes Aug 5, 2018

View reviewed changes

webpack-bot added PR: reviewed-changes-requested and removed PR: unreviewed labels Aug 5, 2018

connorjclark force-pushed the output-lib-array-opt branch from 9ee38f8 to 9625be6 Compare August 9, 2018 21:45

webpack-bot added PR: review-outdated and removed PR: reviewed-changes-requested labels Aug 9, 2018

cli: allow array value for --ouput-library. Fixes webpack#557

0fb0daa

connorjclark force-pushed the output-lib-array-opt branch from 9625be6 to 0fb0daa Compare August 9, 2018 22:01

webpack-bot added PR: CI-ok and removed PR: CI-not-ok labels Aug 9, 2018

evenstensberg requested changes Aug 10, 2018

View reviewed changes

webpack-bot added PR: reviewed-changes-requested and removed PR: review-outdated labels Aug 10, 2018

evenstensberg requested changes Sep 1, 2018

View reviewed changes

evenstensberg requested changes Sep 20, 2018

View reviewed changes

chore: revise long lines

d4cd76a

evenstensberg reviewed Sep 29, 2018

View reviewed changes

evenstensberg approved these changes Sep 30, 2018

View reviewed changes

webpack-bot added the PR: reviewed-approved label Sep 30, 2018

evenstensberg added 3 commits September 30, 2018 09:59

chore: update dev guide

d3a3b87

Merge branch 'master' into output-lib-array-opt

258473f

chore: update small fixes

48646b7

evenstensberg merged commit 9ad7f9b into webpack:master Sep 30, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Output lib array opt #562

Output lib array opt #562

connorjclark commented Aug 2, 2018

dhruvdutt left a comment •

edited

connorjclark commented Aug 2, 2018

ematipico commented Aug 2, 2018 •

edited

evenstensberg Aug 5, 2018

connorjclark Aug 9, 2018

evenstensberg Aug 5, 2018

connorjclark Aug 9, 2018

evenstensberg Aug 5, 2018

connorjclark Aug 9, 2018

webpack-bot commented Aug 9, 2018

connorjclark commented Aug 9, 2018

connorjclark commented Aug 9, 2018

webpack-bot commented Aug 9, 2018

evenstensberg Aug 10, 2018

evenstensberg Sep 1, 2018

evenstensberg left a comment

evenstensberg Sep 1, 2018

evenstensberg Sep 1, 2018

evenstensberg Sep 1, 2018

evenstensberg left a comment

evenstensberg Sep 20, 2018

evenstensberg Sep 20, 2018

evenstensberg Sep 20, 2018

evenstensberg Sep 20, 2018

evenstensberg left a comment

evenstensberg commented Sep 29, 2018

sokra commented Sep 29, 2018

evenstensberg commented Sep 29, 2018

evenstensberg left a comment

		@@ -0,0 +1,5 @@
		./index.js
		-o ../../../js/bin/output/output-library-single/bundle.js

Output lib array opt #562

Output lib array opt #562

Conversation

connorjclark commented Aug 2, 2018

dhruvdutt left a comment • edited

Choose a reason for hiding this comment

connorjclark commented Aug 2, 2018

ematipico commented Aug 2, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

webpack-bot commented Aug 9, 2018

connorjclark commented Aug 9, 2018

connorjclark commented Aug 9, 2018

webpack-bot commented Aug 9, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

evenstensberg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

evenstensberg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

evenstensberg left a comment

Choose a reason for hiding this comment

evenstensberg commented Sep 29, 2018

sokra commented Sep 29, 2018

evenstensberg commented Sep 29, 2018

evenstensberg left a comment

Choose a reason for hiding this comment

dhruvdutt left a comment •

edited

ematipico commented Aug 2, 2018 •

edited