fix tslint warnings #604
Merged
fix tslint warnings #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvdutt
reviewed
Sep 22, 2018
ematipico
suggested changes
Sep 22, 2018
tslint.json
Outdated
| @@ -14,13 +14,7 @@ | |||
| false | |||
| ], | |||
| "no-console": { | |||
| "severity": "warning" | |||
There was a problem hiding this comment.
I would change the configuration to allow only console.error. And we should delete the console.log across the board
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
|
@sendilkumarn Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
|
@sendilkumarn The most important CI builds failed. This way your PR can't be merged. Please take a look at the CI results from travis (failure) and fix these issues. |
ematipico
approved these changes
Sep 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
linting changes
Did you add tests for your changes?
NA
If relevant, did you update the documentation?
NA
Summary
we can switch off console.log warnings and removed that line length issue
Does this PR introduce a breaking change?
NA
Other information
NIL