-
-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests(utils): move tests to TS #688
Merged
Merged
Changes from 20 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
0a590a0
chore(test): add migrate test
sendilkumarn dc79068
chore(lint): revert change
sendilkumarn dd3a76c
chore(test): moved to typescript migrate tests
ematipico aa80327
tests(ts): moved module concatenation plugin to ts
ematipico 5a34a88
tests(migrate): moved to typescript
ematipico 122a770
tests(webpack-scaffold): moved to typescript
hemal7735 3a9656a
tests(utils): copy fixtures to __tests_
hemal7735 a3c9e32
tests(utils): move package-manager.test.js to TS
hemal7735 bb7e3ed
tests(utils): move validate-identifier.test.js to TS
hemal7735 655715d
tests(utils): move resolve-packages.test.js to TS
hemal7735 f470f5f
tests(utils): is-local-path.test.js to TS
hemal7735 182f0bb
tests(utils): move npm-exists.test.js to TS
hemal7735 86b5d7d
tests(utils): move ast-utils.test.js to TS
hemal7735 c2c1479
tests(utils): WIP-test-cases
hemal7735 b351fa2
tests(utils): move recursive-parser.test.js to TS
hemal7735 7bda1ff
tests(utils): move npm-package-exists.test.js to TS
hemal7735 1c8d42a
tests(utils): cleanup .js , __fixtures__ and __snapshots__ files
hemal7735 cbb9bae
chore(utils): clean console recursive-parser.test.ts
hemal7735 46365a2
chore(utils): make options param optional
hemal7735 aec65b8
Merge remote-tracking branch 'GRO/ts-test' into ts-test-utils
hemal7735 8af2a8b
chore: use INode in ast-utils.test.ts
hemal7735 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
packages/utils/is-local-path.test.js → ...ges/utils/__tests__/is-local-path.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
packages/utils/npm-exists.test.js → packages/utils/__tests__/npm-exists.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ematipico I think we were agreeing on non-enclosed paran when single arg?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current
tslint
configuration is strict in those areas.eslint
config is still relaxed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make it as we agreed? Think Emanuelle has some comments there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need to use "arrow-parens": [true, "ban-single-arg-parens"]" in tslint config
more info: https://palantir.github.io/tslint/rules/arrow-parens/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forEach((node) => {
forEach((node: INode) => {
@hemal7735 Can you follow this for all occurrences of
node
andpath
. Checkast-utils.ts
files for reference.