misc: not scaffold 'dist' if the user chooses default

[EvsChen]

As mentioned in #708 , we don't need to scaffold the "dist" property in output path if the entry is single and output path is not chosen by the user.

What kind of change does this PR introduce?
misc
Did you add tests for your changes?
N/A
If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?
No

Other information

[webpack-bot]

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

[evenstensberg]

We will need to do a bit more work here. let outputPath = dist will set dist nonetheless and you will need to move around some logic to check if outputPath is present too. If it is, then set it

[EvsChen]

Hi @evenstensberg , I don't quite get what you mean by "check if outputPath is present".
If the user specifies output, which means outputTypeAnswer.outputType.length !== 0, it will go into the if block and set the output path.

[evenstensberg]

Yes it will, but the default output path is dist. What @TheLarkInn is requesting is that we do not set the option at all in the generated configuration file 👍

[EvsChen]

The dist will not appear in the output. If the user chooses default output and does not input anything, the outputTypeAnswer.outputType.length will be equal to 0 and the output will not be set.

Did I miss some point here? I think the only place that sets the output option is in this if block.

[evenstensberg]

If you set multiple entries and press enter you can see the default output option being set regardless. Idea is to remove that setting entirely

[EvsChen]

As what mentioned in #708, I think @TheLarkInn only wants to remove it for the single entry case.

[evenstensberg]

Webpack will set that property regardless, and it should not be in the generated configuration file if it is set to dist

[webpack-bot]

@EvsChen Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@evenstensberg Please review the new changes.