Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixx: security vulnerability npm release 0.1.2 #723

Merged
merged 1 commit into from Jan 3, 2019
Merged

fixx: security vulnerability npm release 0.1.2 #723

merged 1 commit into from Jan 3, 2019

Conversation

eavichay
Copy link
Contributor

@eavichay eavichay commented Jan 2, 2019

What kind of change does this PR introduce?
Security issue see #721

Did you add tests for your changes?
No

If relevant, did you update the documentation?
No

Does this PR introduce a breaking change?
No

@jsf-clabot
Copy link

jsf-clabot commented Jan 2, 2019 •
edited

CLA assistant check
All committers have signed the CLA.

@evenstensberg evenstensberg changed the title See #721 fixx: security vulnerability npm release 0.1.2 Jan 2, 2019
evenstensberg
evenstensberg approved these changes Jan 2, 2019
View reviewed changes
Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ematipico
ematipico suggested changes Jan 2, 2019
View reviewed changes
Copy link
Contributor

@ematipico ematipico left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package-lock.json file is missing, that's why the CI is failing. Could you add it to the PR, please?

@evenstensberg
Copy link
Member

I'll fix json pkg

@evenstensberg evenstensberg merged commit 4d9c847 into webpack:master Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico requested changes

@rishabh3112 rishabh3112 rishabh3112 approved these changes

@evenstensberg evenstensberg evenstensberg approved these changes

Assignees
No one assigned
Labels
PR: reviewed-approved PR: reviewed-changes-requested PR: small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@eavichay @jsf-clabot @evenstensberg @ematipico @rishabh3112 @webpack-bot