docs(readme): adds deprecated warning and commands #955
Conversation
adds deprecated commands warning
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
README.md
Outdated
| @@ -57,6 +57,12 @@ Supporting developers is an important task for webpack CLI. Thus, webpack CLI pr | |||
| - [`webpack-cli generate-loader`](./packages/generate-loader/README.md#webpack-cli-generate-loader) - Initiate new loader project. | |||
| - [`webpack-cli serve`](./packages/serve/README.md#webpack-cli-serve) - Use webpack with a development server that provides live reloading. | |||
|
|
|||
| > Deprecated commands as of v3.3.3 | |||
There was a problem hiding this comment.
Would it make sense to explicitly say Deprecated commands since v3.3.4 here
There was a problem hiding this comment.
I guess the current is fine. but it would be good if we say which version still supports those command. What do you think ?
There was a problem hiding this comment.
Might do a range instead <= 3.3.3
There was a problem hiding this comment.
Yeah....this one can be done 👍
There was a problem hiding this comment.
@anikethsaha Yeah, the intention is to make it easier for people to catch the change. Most of them (including me) will just skim the readme at first. It will be really catchy if we have specified the version in which the change came into effect.
I like @evenstensberg suggestion too.
There was a problem hiding this comment.
We decided on since right?
|
Could you address changes here and rebase? |
pranshuchittora
dismissed stale reviews from wizardofhogwarts, misterdev, anikethsaha, anshumanv, and evenstensberg
via
41ee8ca
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-approved
PR: reviewed-changes-requested
labels
|
@pranshuchittora Thanks for your update. I labeled the Pull Request so reviewers will review it again. @rishabh3112 Please review the new changes. |
|
Are they removed or deprecated? |
|
Removed |
adds deprecated commands warning
What kind of change does this PR introduce?
docs