Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: Bumps chokidar to 2.0.3 #1403

Closed
wants to merge 1 commit into from
Closed

Conversation

jeremyzahner
Copy link

  • This is a bugfix
  • This is a code refactor
  • This is a test update
  • This is a typo fix
  • This is a metadata update

Motivation / Use-Case

While updating a project leveraging webpack-dev-server to Node v10 we've encountered an issue with the engine compatibility definition for upath. They have fixed that in their own repo (see anodynos/upath#14).

webpack-dev-server uses upath through chokidar. They have also fixed this engine requirement (as in locking upath to a certain version before the fix) in a recent patch (see paulmillr/chokidar#710).

Breaking Changes

None

@jsf-clabot
Copy link

jsf-clabot commented May 9, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented May 9, 2018

Codecov Report

Merging #1403 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1403   +/-   ##
=======================================
  Coverage   79.14%   79.14%           
=======================================
  Files           6        6           
  Lines         494      494           
  Branches      160      160           
=======================================
  Hits          391      391           
  Misses        103      103

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33be88d...f41d696. Read the comment docs.

@alexander-akait
Copy link
Member

@jeremyzahner our semver allow install 2.0.3, why we should change this in package.json? Just update own lock file and all

@jeremyzahner
Copy link
Author

@evilebottnawi Nevermind, it seems like i've had an issue with a lockfile beeing cached.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants