Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency chokidar to v3 #1902

Merged
merged 2 commits into from
Jun 5, 2019
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 17, 2019

This PR contains the following updates:

Package Type Update Change
chokidar dependencies major ^2.1.6 -> ^3.0.1

Release Notes

paulmillr/chokidar

v3.0.1

Compare Source

  • Fixes "Assertion failed" errors when a watcher is closed
  • General optimizations

v3.0.0

Compare Source

Massive CPU & RAM consumption improvements. 17x package & deps size reduction. Node 8+-only


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #1902 into next will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1902      +/-   ##
==========================================
+ Coverage   92.35%   92.47%   +0.11%     
==========================================
  Files          28       28              
  Lines        1060     1076      +16     
  Branches      322      322              
==========================================
+ Hits          979      995      +16     
  Misses         77       77              
  Partials        4        4
Impacted Files Coverage Δ
client-src/default/utils/log.js 100% <0%> (ø) ⬆️
client-src/default/utils/getCurrentScriptSource.js 100% <0%> (ø) ⬆️
client-src/default/utils/createSocketUrl.js 100% <0%> (ø) ⬆️
client-src/default/utils/reloadApp.js 100% <0%> (ø) ⬆️
client-src/default/index.js 92.22% <0%> (+0.65%) ⬆️
client-src/default/utils/sendMessage.js 85.71% <0%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c29ba7a...a5140b9. Read the comment docs.

@renovate renovate bot force-pushed the renovate/chokidar-3.x branch 11 times, most recently from d877cff to 5f84fe7 Compare May 24, 2019 15:37
@renovate renovate bot force-pushed the renovate/chokidar-3.x branch 14 times, most recently from 2355329 to b00a886 Compare June 1, 2019 15:23
@hiroppy hiroppy changed the base branch from master to next June 5, 2019 18:43
@renovate
Copy link
Contributor Author

renovate bot commented Jun 5, 2019

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be great migrate on webpack watch api, but it is not high critically so we ca merge this as is right now

@hiroppy hiroppy merged commit 2323d45 into next Jun 5, 2019
@hiroppy hiroppy deleted the renovate/chokidar-3.x branch June 5, 2019 20:18
knagaitsev pushed a commit to knagaitsev/webpack-dev-server that referenced this pull request Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants