refactor(server): move publicPath configuration from CLI to API #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knagaitsev
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2098 +/- ##
==========================================
+ Coverage 94.46% 94.49% +0.03%
==========================================
Files 32 33 +1
Lines 1210 1218 +8
Branches 334 337 +3
==========================================
+ Hits 1143 1151 +8
Misses 65 65
Partials 2 2
Continue to review full report at Codecov.
|
| @@ -58,6 +59,8 @@ class Server { | |||
| this.compiler = compiler; | |||
| this.options = options; | |||
|
|
|||
| setPublicPath(compiler, options); | |||
There was a problem hiding this comment.
Let's move this in updateCompiler
There was a problem hiding this comment.
@evilebottnawi this is not altering the compiler at all though, only using the compiler's option data to set devServer.publicPath. But if you still think it should be there I have no strong opinion.
|
This pr should be changed to the next. |
|
I think I will just open new PR on next |
6 tasks
|
Closing in favor of #2099 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Not yet
Motivation / Use-Case
This is part of the effort to move configuration changes out of the CLI and into the API. The goal here is to set the
publicPathoption in the API if it is not already set.Breaking Changes
No breaking changes on CLI.
On API, if a user was not specifying a
publicPathin the past, it would not be set. Now, it will be set based oncompiler.options.output.publicPath, if it exists. Should this PR be onnextfor this reason?Additional Info