refactor(server): move publicPath changes from CLI to API #2099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Codecov Report
@@ Coverage Diff @@
## next #2099 +/- ##
==========================================
+ Coverage 93.57% 93.61% +0.04%
==========================================
Files 33 34 +1
Lines 1245 1253 +8
Branches 363 366 +3
==========================================
+ Hits 1165 1173 +8
Misses 75 75
Partials 5 5
Continue to review full report at Codecov.
|
lib/Server.js
Outdated
| @@ -59,6 +60,8 @@ class Server { | |||
| this.compiler = compiler; | |||
| this.options = options; | |||
|
|
|||
| setPublicPath(compiler, options); | |||
There was a problem hiding this comment.
Anyway, let's move this in updateCompiler
This was referenced Jul 10, 2019
Because opn was renamed to open.
knagaitsev
force-pushed
the
next-setPublicPath-cli-change
branch
from
04f3b1a
to
ed0050e
Compare
|
Closing in favor of #2174 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Not yet
Motivation / Use-Case
Move #2098 to
nextbranch.Breaking Changes
Yes
Additional Info
The block I deleted from
createConfigwas changed since the lastnextrebase, but it should be easy to deal with.