Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve error handling for WebsocketServer #5061

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No

Motivation / Use-Case

Backport #5038 to v4

Fix #5018

Breaking Changes

No

Additional Info

Need to do a patch release for v4

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (99f66cb) 91.96% compared to head (7dbb343) 90.39%.

Files Patch % Lines
lib/servers/WebsocketServer.js 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v4    #5061      +/-   ##
==========================================
- Coverage   91.96%   90.39%   -1.57%     
==========================================
  Files          16       16              
  Lines        1704     1707       +3     
  Branches      647      647              
==========================================
- Hits         1567     1543      -24     
- Misses        126      150      +24     
- Partials       11       14       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@snitin315 snitin315 changed the base branch from master to v4 February 20, 2024 20:19
@snitin315 snitin315 closed this Feb 20, 2024
@snitin315 snitin315 reopened this Feb 20, 2024
@alexander-akait alexander-akait merged commit 54c84df into v4 Feb 21, 2024
54 of 66 checks passed
@alexander-akait alexander-akait deleted the fix-WebsocketServer branch February 21, 2024 11:06
@alexander-akait
Copy link
Member

When I finished webpack/webpack-cli#4045, we will need to backport these changes too, I will show how to do it

@alexander-akait
Copy link
Member

And I will make a release

@profispojka
Copy link

profispojka commented Jul 10, 2024

I am still having this error on latest webpack + vue 2.7.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Invalid WebSocket frame: RSV1 must be clear in Vue.js application with webpack-dev-server
3 participants