Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document webpack change: make browserslist the default target when browserslist config is available #4009

Closed
webpack-bot opened this issue Sep 28, 2020 · 1 comment · Fixed by #4016
Closed

Document webpack change: make browserslist the default target when browserslist config is available #4009

webpack-bot opened this issue Sep 28, 2020 · 1 comment · Fixed by #4016
Assignees
@smelukov
Projects
webpack 5

Comments

@webpack-bot
Copy link

A pull request by @sokra was merged and maintainers requested a documentation change.

See pull request: webpack/webpack#11541

What kind of change does this PR introduce?
defaults change

Did you add tests for your changes?
yes

Does this PR introduce a breaking change?
yes

What needs to be documented once your changes are merged?
when browserslist info is available, this will be used by default
@smelukov smelukov self-assigned this Sep 30, 2020
smelukov added a commit to smelukov/webpack.js.org that referenced this issue Sep 30, 2020
@smelukov
(configuration): browserslist output.target and output.environment (c…
c9621bc 
…loses webpack#4009)
@smelukov smelukov mentioned this issue Sep 30, 2020
Merged
smelukov added a commit to smelukov/webpack.js.org that referenced this issue Sep 30, 2020
@smelukov
(configuration): browserslist output.target and output.environment (c…
e41eb07 
…loses webpack#4009)
@sokra sokra added this to Important in webpack 5 Oct 7, 2020
@sokra
Copy link
Member

sokra commented Oct 7, 2020

This should be merged into #3968

@sokra sokra closed this as completed Oct 7, 2020
webpack 5 automation moved this from Important to Done Oct 7, 2020
sokra pushed a commit that referenced this issue Oct 8, 2020
@smelukov @EugeneHlushko @montogeek
Added browserslist output.target and output.environment (#4016)
4166e49 
* (configuration): browserslist output.target and output.environment (closes #4009)

* Apply suggestions from code review

Co-authored-by: Eugene Hlushko <jhlushko@gmail.com>

* Apply suggestions from code review

Co-authored-by: Fernando Montoya <montogeek@gmail.com>

Co-authored-by: Eugene Hlushko <jhlushko@gmail.com>
Co-authored-by: Fernando Montoya <montogeek@gmail.com>
montogeek added a commit that referenced this issue Oct 9, 2020
@smelukov @EugeneHlushko
@montogeek @sokra
docs(config) Add more target documentation (#4047)
2428276 
* (configuration): browserslist output.target and output.environment (closes #4009)

* Apply suggestions from code review

Co-authored-by: Eugene Hlushko <jhlushko@gmail.com>

* Apply suggestions from code review

Co-authored-by: Fernando Montoya <montogeek@gmail.com>

* (docs): target

* (docs): some fixes

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: Fernando Montoya <montogeek@gmail.com>

Co-authored-by: Eugene Hlushko <jhlushko@gmail.com>
Co-authored-by: Fernando Montoya <montogeek@gmail.com>
Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
aoberoi added a commit to aoberoi/webpack.js.org that referenced this issue Dec 15, 2023
@aoberoi
Clarify interaction between --node-env and mode
d00cbec 
The interpretation of the current description is ambiguous, as it pertains to how a configuration function can or cannot benefit from the use of `--node-env` as a way to set `mode`. One might interpret it as if that happens before the configuration function is invoked, and therefore should be available to use for logic like switching in the function. That would be wrong. This update makes it clear that the assignment of a default `mode` based on `--node-env` happens after the configuration function is executed.

Related: webpack#4009 

Fixes webpack#3992
@aoberoi aoberoi mentioned this issue Dec 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smelukov smelukov

Labels
None yet
Projects
webpack 5
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added browserslist output.target and output.environment smelukov/webpack.js.org
3 participants
@sokra @smelukov @webpack-bot