Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix stylus loader link #3992

Merged
merged 3 commits into from
Sep 21, 2020
Merged

chore: fix stylus loader link #3992

merged 3 commits into from
Sep 21, 2020

Conversation

anshumanv
Copy link
Member

Missed in #3903

  • Read and sign the CLA. PRs that haven't signed it won't be accepted.
  • Make sure your PR complies with the writer's guide.
  • Review the diff carefully as sometimes this can reveal issues.
  • Do not abandon your Pull Request: Stale Pull Requests.
  • Remove these instructions from your PR as they are for your eyes only.

@vercel
Copy link

vercel bot commented Sep 19, 2020 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/44ykryl42
✅ Preview: https://webpack-js-org-git-fork-anshumanv-temp.webpack-docs.vercel.app

EugeneHlushko
EugeneHlushko requested changes Sep 21, 2020
View reviewed changes
Copy link
Member

@EugeneHlushko EugeneHlushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think its now available through the docs

src/content/loaders/index.md Outdated Show resolved Hide resolved
@anshumanv @EugeneHlushko
Update src/content/loaders/index.md
2a68f57 
Co-authored-by: Eugene Hlushko <jhlushko@gmail.com>
@EugeneHlushko
Copy link
Member

Maybe the branch is outdated, stylus page wasnt available on preview. Trying with update now

@EugeneHlushko EugeneHlushko merged commit 89faefb into webpack:master Sep 21, 2020
@EugeneHlushko
Copy link
Member

Thanks!

@anshumanv anshumanv deleted the temp branch September 21, 2020 17:12
aoberoi added a commit to aoberoi/webpack.js.org that referenced this pull request Dec 15, 2023
@aoberoi
Clarify interaction between --node-env and mode
d00cbec 
The interpretation of the current description is ambiguous, as it pertains to how a configuration function can or cannot benefit from the use of `--node-env` as a way to set `mode`. One might interpret it as if that happens before the configuration function is invoked, and therefore should be available to use for logic like switching in the function. That would be wrong. This update makes it clear that the assignment of a default `mode` based on `--node-env` happens after the configuration function is executed.

Related: webpack#4009 

Fixes webpack#3992
@aoberoi aoberoi mentioned this pull request Dec 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EugeneHlushko EugeneHlushko EugeneHlushko approved these changes

Assignees
No one assigned
Labels
Loaders
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anshumanv @EugeneHlushko