Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(getting-started): use var instead to match the rest of the guides #2768

Closed
wants to merge 2 commits into from

Conversation

kelvinau
Copy link

I understand that there's a PR for this similar issue already #2614, but it's been 3 months and we haven't had any updates from the last PR regarding to the const reassignment fix.

A simpler fix will be only changing docs(getting-started) to replace it let with var, as that's the only part inconsistent with the others.

@EugeneHlushko
Copy link
Member

Hello @kelvinau
I understand how critical it is to update this example with the modern let syntax, but i would suggest we don't rush and wait two more weeks here and give original author a warning or something.

What do you think @montogeek ?

@kelvinau
Copy link
Author

Understood. I can make the changes for let and const instead too, if @anayadesign hasn't responded after.

@montogeek
Copy link
Member

@kelvinau Friendly ping

@kelvinau
Copy link
Author

This was fixed by #2962 which extended #2614 already.

@kelvinau kelvinau closed this Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants