-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(parser): Improving parser hooks documentation #2790
docs(parser): Improving parser hooks documentation #2790
Conversation
I've differentiated between:
This page only shows a list of parser hooks so I renamed it "Parser Hooks" to be coherent to "Compiler Hooks" and "Compilation Hooks". Since this is what I've learned debugging the parser hooks I really appreciate every feedback. @montogeek :) |
I've updated this branch, it is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very great addition, but i have added some comments to be addressed or discussed
Thanks @EugeneHlushko for reviewing! I've included your changes and made some more improvements following your suggestion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It took some effort but i think it looks good :)
@montogeek mind taking a look at this too? |
Friendly ping :) @montogeek |
Double checked it again, looks good and seems doesn't get any more attention. Merging |
Thanks! |
I'm working on improving the current documentation for the parser (link), this is a work in progress and I've opened this PR to have some feedback.
I'm debugging how the parser works, so I may misunderstand the purpose of some hooks, feedbacks are appreciated
In
statement
hook I'm listing all the types of the statements you can receive as callback parameter, I think it can be useful, but it is 36 rows long, is it ok to put it there?Since this page only shows a list of all the Parser Hooks, I would like to rename it "Parser Hooks" to be coherent to "Compiler Hooks" and "Compilation Hooks", is it a good idea?
![screenshot 2019-01-30 at 17 21 04](https://user-images.githubusercontent.com/11232797/51995750-9a6b9b00-24b3-11e9-809c-e0b60bde6589.png)
Thanks