Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling consistency and typos #3165

Merged
merged 6 commits into from
Jul 6, 2019

Conversation

kswedberg
Copy link
Contributor

Hi @montogeek , here is my first round of tweaks to the content, mostly limited to the api and concepts directories. Most of the changes are very subtle—adding a missing comma here, ensuring parallel construction there—but I hope the overall effect is more clear and coherent prose.

Let me know if you have any questions/concerns about the changes. And if you find them helpful, I'll work on the other files soon.

@netlify
Copy link

netlify bot commented Jul 3, 2019

Preview is ready

Built with commit d36ac18

https://deploy-preview-3165--webpackjsorg-netlify.netlify.com

@EugeneHlushko EugeneHlushko added the Grammar A pull request focused on grammar correction. label Jul 4, 2019
Copy link
Member

@EugeneHlushko EugeneHlushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good although i have a couple of questions

src/content/api/module-methods.md Outdated Show resolved Hide resolved
src/content/concepts/configuration.md Show resolved Hide resolved
src/content/concepts/entry-points.md Show resolved Hide resolved
src/content/concepts/index.md Outdated Show resolved Hide resolved
src/content/concepts/manifest.md Outdated Show resolved Hide resolved
@kswedberg
Copy link
Contributor Author

@EugeneHlushko , thanks a lot for reviewing my PR. I’m on vacation at the moment without my laptop, but I’ll try to update the PR with your suggested changes and resubmit either tonight or tomorrow.

@kswedberg
Copy link
Contributor Author

Also, I’ll fix the conflict, keeping master. That must have crept in when I tried to rebase.

@kswedberg
Copy link
Contributor Author

Okay, I've made the updates according to @EugeneHlushko's recommendations. The only outstanding issue is the line I just flagged with the incomplete sentence. Otherwise, should be all set to merge.

@EugeneHlushko EugeneHlushko merged commit b7d5bd0 into webpack:master Jul 6, 2019
@EugeneHlushko
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Concepts Contribute Grammar A pull request focused on grammar correction.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants