Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lazy-loading.md #4354

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

LuisRodNuezDev
Copy link

@LuisRodNuezDev LuisRodNuezDev commented Dec 31, 2020

I had to add the CleanWebpackPlugin and the HtmlWebpackPlugin in the webpack.config.js file in order to get the same results that were shown in the example after the npm run build command was ran. These two plugins were not present in the Code Splitting subsection of the Guides section.

describe your changes...

  • Read and sign the CLA. PRs that haven't signed it won't be accepted.
  • Make sure your PR complies with the writer's guide.
  • Review the diff carefully as sometimes this can reveal issues.
  • Do not abandon your Pull Request: Stale Pull Requests.
  • Remove these instructions from your PR as they are for your eyes only.

I had to add the CleanWebpackPlugin and the HtmlWebpackPlugin in the webpack.config.js file in order to get the same results that were shown in the example after the npm run build command was ran.  These two plugins were not present in the Code Splitting subsection of the Guides section.
@vercel
Copy link

vercel bot commented Dec 31, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/9c0mcdkxb
✅ Preview: https://webpack-js-org-git-fork-tazexprez-patch-1.webpack-docs.vercel.app

@chenxsan
Copy link
Member

I think the situation here is a little complex. That Lazy Loading guide was based on Code Splitting guide which was based on others, and those plugins are presented over there. Which means you have to finish other guides before Lazy Loading, otherwise you might get a problem.

I have a plan to refactor the guides so they're not deeply coupled. Hope it can save us from those problems in future.

@LuisRodNuezDev
Copy link
Author

Thank you for your help. I will keep this in mind when going through other guides in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants