Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples): fix StackBlitz example for module federation #5090

Conversation

SamVerschueren
Copy link
Contributor

This PR fixes the link when clicking on the StackBlitz button. It will install the dependencies, run the npm start command and open a second blank terminal.

I also removed the .stackblitzrc because it's covered by the query parameters and allows more flexibility like opening a second or third terminal and what not. So in this case, the .stackblitzrc is not needed.

@vercel
Copy link

vercel bot commented Jun 16, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/GCrjQ4Twr1YskjphpNFrcpHss2DU
✅ Preview: https://webpack-js-org-git-fork-samverschueren-docs-a48f79-webpack-docs.vercel.app

@chenxsan
Copy link
Member

@SamVerschueren
Copy link
Contributor Author

Good catch!

Copy link
Member

@chenxsan chenxsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@chenxsan chenxsan merged commit 445ed65 into webpack:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants