feat(performancebudgets): set warnings in console off by default, how…

…ever should still display in stats (#3604)
webpack · Dec 28, 2016 · 5f14559 · 5f14559
1 parent 92a8be2
commit 5f14559
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 6 deletions.
diff --git a/lib/WebpackOptionsDefaulter.js b/lib/WebpackOptionsDefaulter.js
@@ -73,12 +73,7 @@ function WebpackOptionsDefaulter() {
 
 	this.set("performance.maxAssetSize", 250000);
 	this.set("performance.maxEntrypointSize", 250000);
-	this.set("performance.hints", "make", function(options) {
-		if(options.target === "web" || options.target === "webworker")
-			return "warning";
-		else
-			return false;
-	});
+	this.set("performance.hints", false);
 
 	this.set("resolve", {});
 	this.set("resolve.unsafeCache", true);

diff --git a/test/fixtures/temp-1000/file.js b/test/fixtures/temp-1000/file.js
@@ -0,0 +1 @@
+require('./file2'); again
diff --git a/test/fixtures/temp-1000/file2.js b/test/fixtures/temp-1000/file2.js
@@ -0,0 +1 @@
+original
diff --git a/test/statsCases/performance-no-async-chunks-shown/webpack.config.js b/test/statsCases/performance-no-async-chunks-shown/webpack.config.js
@@ -3,6 +3,9 @@ module.exports = {
 		main: "./index",
 		sec: "./index2"
 	},
+	performance: {
+		hints: "warning"
+	},
 	stats: {
 		colors: true,
 		hash: false,

diff --git a/test/statsCases/preset-normal-performance-ensure-filter-sourcemaps/webpack.config.js b/test/statsCases/preset-normal-performance-ensure-filter-sourcemaps/webpack.config.js
@@ -1,5 +1,8 @@
 module.exports = {
 	devtool: "sourcemap",
+	performance: {
+		hints: "warning"
+	},
 	entry: "./index",
 	stats: {
 		hash: false,

diff --git a/test/statsCases/preset-normal-performance/webpack.config.js b/test/statsCases/preset-normal-performance/webpack.config.js
@@ -1,5 +1,8 @@
 module.exports = {
 	entry: "./index",
+	performance: {
+		hints: "warning"
+	},
 	stats: {
 		hash: false,
 		colors: true