Merge pull request #13142 from webpack/bugfix/publicPath-importModule

fix passing publicPath to `this.importModule`
webpack · Apr 14, 2021 · fbe2a59 · fbe2a59
2 parents 7ee3bab + 8d3a230
commit fbe2a59
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 6 deletions.
diff --git a/lib/dependencies/LoaderPlugin.js b/lib/dependencies/LoaderPlugin.js
@@ -31,6 +31,7 @@ const LoaderImportDependency = require("./LoaderImportDependency");
 /**
  * @typedef {Object} ImportModuleOptions
  * @property {string=} layer the target layer
+ * @property {string=} publicPath the target public path
  */
 
 class LoaderPlugin {
@@ -199,7 +200,11 @@ class LoaderPlugin {
 									}
 									compilation.executeModule(
 										referencedModule,
-										{},
+										{
+											entryOptions: {
+												publicPath: options.publicPath
+											}
+										},
 										(err, result) => {
 											if (err) return callback(err);
 											for (const d of result.fileDependencies) {

diff --git a/test/configCases/loader-import-module/css/index.js b/test/configCases/loader-import-module/css/index.js
@@ -10,6 +10,6 @@ it("should be able to use build-time code", () => {
 		'body { background: url("/public/assets/file.png?1"); color: #f00; }'
 	);
 	expect(otherStylesheet).toBe(
-		'body { background: url("/public/assets/file.jpg"); color: #0f0; }'
+		'body { background: url("/other/assets/file.jpg"); color: #0f0; }'
 	);
 });
diff --git a/test/configCases/loader-import-module/css/loader.js b/test/configCases/loader-import-module/css/loader.js
@@ -1,6 +1,7 @@
 exports.pitch = async function (remaining) {
 	const result = await this.importModule(
-		this.resourcePath + ".webpack[javascript/auto]" + "!=!" + remaining
+		this.resourcePath + ".webpack[javascript/auto]" + "!=!" + remaining,
+		this.getOptions()
 	);
 	return result.default || result;
 };
diff --git a/test/configCases/loader-import-module/css/webpack.config.js b/test/configCases/loader-import-module/css/webpack.config.js
@@ -16,9 +16,21 @@ module.exports = {
 		},
 		rules: [
 			{
-				test: /stylesheet\.js$/,
-				use: "./loader",
-				type: "asset/source"
+				oneOf: [
+					{
+						test: /other-stylesheet\.js$/,
+						loader: "./loader",
+						options: {
+							publicPath: "/other/"
+						},
+						type: "asset/source"
+					},
+					{
+						test: /stylesheet\.js$/,
+						use: "./loader",
+						type: "asset/source"
+					}
+				]
 			},
 			{
 				test: /\.jpg$/,